Repository navigation
chore(compiler): refactor emoji rendering logic in compiler - #1060
Merged
Merged
Conversation
refactor emoji rendering
rm logs
fix code
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Contributor
Author
|
@anikethsaha what changes are you requesting? 😄 |
Contributor
None, you have fixed those already, this is fine |
evenstensberg
approved these changes
Aug 26, 2019
25 of 29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor emoji rendering
What kind of change does this PR introduce?
refactor emoji rendering logic, save loops.
Did you add tests for your changes?
No
If relevant, did you update the documentation?
NA
Summary
Compare one whether to render emojis or not
Does this PR introduce a breaking change?
No
Other information