fix: resolve opts when no-config & fix vulns#1024
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
bin/utils/convert-argv.js
Outdated
|
|
||
| // process Promise | ||
| if (typeof options.then === "function") { | ||
| if (options && typeof options.then === "function") { |
There was a problem hiding this comment.
Now that you have the if/else, options will never be undefined right? So this additional check is not needed
There was a problem hiding this comment.
checks for options.then object prop so will throw. We're setting props on the object later these checks, I think we "assumed" we either found or did not find the props before validating args that aren't protected by 0CJS (entry and output)
There was a problem hiding this comment.
I'm not talking about .then, I'm talking about options &&. It's redundant. You already assigned it before with options = {}.
So or you keep this check and remove the assignment or keep the assignment and remove the check.
There was a problem hiding this comment.
Thanks for pointing it out, changed now!
Co-Authored-By: Emanuele <[email protected]>
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@evenstensberg Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
Co-Authored-By: Emanuele <[email protected]>
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Please review assignment/check of options
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
4 participants
What kind of change does this PR introduce?
Closes #1023
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
Dupes out of resolving options if there are none to throw an error
Does this PR introduce a breaking change?
No
Other information
N/A