Negated flags #1240

Activity

1. ematipico

   added

   Feature

   webpack ecosystem

   on Feb 19, 2020
2. snitin315 commented on Feb 23, 2020

   

   snitin315

   on Feb 23, 2020

   Contributor

   More actions

   @ematipico I would like to work on this issue. It would be great if you can point me to some reference or share any tip/prerequisite .
3. rishabh3112 commented on Feb 23, 2020

   

   rishabh3112

   on Feb 23, 2020

   Contributor

   More actions

   Thanks for trying to work on the issue.
   You can look at how other flags are added in the CLI, that would be enough to get you working on the issue.
   You can ask for more help here if you need in future 🙌
4. snitin315 commented on Feb 23, 2020

   

   snitin315

   on Feb 23, 2020

   Contributor

   More actions

   @rishabh3112 thanks , Looking into it.
5. snitin315 commented on Feb 26, 2020

   

   snitin315

   on Feb 26, 2020

   Contributor

   More actions

   @rishabh3112 correct me if I'm wrong the --no-mode flag should set mode = "none" .?
6. ematipico commented on Feb 26, 2020

   

   ematipico

   on Feb 26, 2020

   ContributorAuthor

   More actions

   It depends on us. What do you think?
7. snitin315 commented on Feb 26, 2020

   

   snitin315

   on Feb 26, 2020

   Contributor

   More actions

   I think it should set mode = "none"
8. ematipico commented on Feb 26, 2020

   

   ematipico

   on Feb 26, 2020

   ContributorAuthor

   More actions

   Sounds good :)

   👍React with 👍1Reacted by Nitin Kumar
9. snitin315 commented on Feb 27, 2020

   

   snitin315

   on Feb 27, 2020

   Last edited by snitin315

   Contributor

   More actions

   @ematipico @rishabh3112 , I am able to add nomode or no_mode but I can't pass no-mode in the code below in zero-config.js like this -

   function getEnvFromOptionsAndMode(mode, optionsObject) {
        const { dev, prod, no-mode } = optionsObject;
   
   

   Whats the trick here to do so?
10. anshumanv commented on Feb 27, 2020

    

    anshumanv

    on Feb 27, 2020

    Contributor

    More actions

    - would be seen as an operator while destructuring since what you're destructuring is not a valid key, syntactically wrong.

    Maybe add an alias variable for the flag like --no-mode stores a property is stored with key no_mode?
11. snitin315 commented on Feb 27, 2020

    

    snitin315

    on Feb 27, 2020

    Last edited by snitin315

    Contributor

    More actions

    I think I should make a PR and move the discussion over there.
12. ematipico commented on Feb 27, 2020

    

    ematipico

    on Feb 27, 2020

    ContributorAuthor

    More actions

    As the file says, that's a file we use for covering the case the user doesn't use any configuration.

    The reading and parsing of the new flag will occur inside the group you decide to put.
13. snitin315

    closed this as completedin #1668on Jul 7, 2020