Skip to content

Commit ad60c8c

Browse files
test: don't force kill the dev server on slow shutdowns
execa sends SIGKILL 5 seconds after SIGTERM, so a slow graceful shutdown lost its exit code on macOS. Claude-Session: https://claude.ai/code/session_013FhutRFjuQemBzekJMYcqL
1 parent d230ec8 commit ad60c8c

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

‎test/serve/error-handling/serve-error-handling.test.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,9 @@ describeDevServer6("serve error handling", () => {
120120
port,
121121
],
122122
{
123+
// execa kills with `SIGKILL` when the process is still alive 5 seconds after
124+
// `SIGTERM`, a graceful shutdown can take longer on slow machines
125+
forceKillAfterDelay: false,
123126
handler: (proc) => {
124127
let output = "";
125128
let serverOutput = "";

0 commit comments

Comments
 (0)