Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump webassemblyjs #8786

Merged
merged 1 commit into from
Feb 15, 2019
Merged

bump webassemblyjs #8786

merged 1 commit into from
Feb 15, 2019

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Feb 14, 2019

Fix custom section decoding.

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

Fixes #8781 rustwasm/wasm-bindgen#1246

@xtuc
chore: bump webassemblyjs
e4ce645 
Fix custom section decoding.
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@xtuc xtuc changed the title chore: bump webassemblyjs bump webassemblyjs Feb 14, 2019
sendilkumarn
sendilkumarn approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@sendilkumarn sendilkumarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This was referenced Feb 14, 2019
Closed
Closed
Closed
@thavlik
Copy link

thavlik commented Feb 15, 2019

I can confirm this fix addresses the issue in question. For search engines, this was the relevant error code:

Module parse failed: Unexpected section: 0xfe
You may need an appropriate loader to handle this file type.
Error: Unexpected section: 0xfe

@sokra sokra merged commit 196cb81 into webpack:master Feb 15, 2019
@sokra
Copy link
Member

sokra commented Feb 15, 2019

Thanks

@hskang9 hskang9 mentioned this pull request Feb 15, 2019
Merged
@xtuc xtuc deleted the chore-bump-webassemblyjs19 branch February 15, 2019 13:28
@fitzgen fitzgen mentioned this pull request Feb 19, 2019
Closed
@jljorgenson18 jljorgenson18 mentioned this pull request Jun 23, 2019
Closed
@ghost ghost mentioned this pull request Aug 14, 2019
Closed
jingkirbb added a commit to jingkirbb/create-wasm-app that referenced this pull request Aug 4, 2024
@jingkirbb
Change webpack version into fixed version
8a6917b 
This fixes [webpack error]
(rustwasm/wasm_game_of_life#22) due to the recent [rust-bindgen](https://github.com/rust-lang/rust-bindgen) update.
Change in the version desribed [here](webpack/webpack#8786).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sendilkumarn sendilkumarn sendilkumarn approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest webpack no longer works with rustwasm
5 participants
@xtuc @webpack-bot @thavlik @sokra @sendilkumarn