Auto-add names to factory functions in FunctionModuleTemplatePlugin#4858
Closed
sophiebits wants to merge 1 commit into
Closed
Auto-add names to factory functions in FunctionModuleTemplatePlugin#4858sophiebits wants to merge 1 commit into
sophiebits wants to merge 1 commit into
Conversation
I was trying to profile my app's startup in the Chrome devtools. I got this:  Unfortunately, each of the "(anonymous)" blocks is a module factory created by webpack, and it's not easy to tell which is which. This commit adds a slightly mangled version of the path name as that factory function's name, which gives us a profile that is actually useful: 
|
|
Author
|
Just putting this up for a discussion; happy to do the work to add/update tests if this seems desirable. cc @gaearon since I bet you'd like this (I was profiling a CRA app) |
Contributor
|
I like this! Maybe |
Author
|
I wanted to keep in-file separators (ex: the dot before an extension) as well as slashes (as $). If we strip the former then we can make the latter an underscore. |
Author
|
Even switching them might look better actually. I'll try. |
Member
|
There is already a |
Member
I like it. |
Contributor
|
@spicyj Please review the following output log for errors: See complete report here. |
Member
|
This PR is not needed. You can use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to profile my app's startup in the Chrome devtools. I got this:
Unfortunately, each of the "(anonymous)" blocks is a module factory created by webpack, and it's not easy to tell which is which.
This commit adds a slightly mangled version of the path name as that factory function's name, which gives us a profile that is actually useful:
Much better.
~~
What kind of change does this PR introduce?
minor feature
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no