Skip to content

refactor(types): type rule effects and the CLI config walker - #23034

Merged
alexander-akait merged 1 commit into
mainfrom
refactor/typed-rule-effects-and-cli
Oct 31, 2026
Merged

refactor(types): type rule effects and the CLI config walker#23034
alexander-akait merged 1 commit into
mainfrom
refactor/typed-rule-effects-and-cli

Conversation

@alexander-akait

@alexander-akait alexander-akait commented Oct 31, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary

Follow-up to #23021: removes 27 of the 29 inferred any left in lib/module/NormalModuleFactory.js and lib/config/cli.js. Public types are unchanged.

  • NormalModuleFactory: a rule's use effects are cast to LoaderItem, which is the shape UseEffectRulePlugin always builds. Every other effect value is read as unknown, then merged into or assigned to its setting as before: 
    // before: r.value is any, so any setting accepted anything unchecked
settings[type] = cachedCleverMerge(settings[type], r.value);
// after: the value is unknown and narrowed before it is merged
const value = /** @type {unknown} */ (r.value);
const current = settings[type];
settings[type] = typeof value === "object" && value !== null && typeof current === "object" && current !== null
	? cachedCleverMerge(current, value)
	: value;
    The merge-or-assign logic is the same; it now reads settings[type] once instead of three times.
  • cli.js: the path walker in getObjectAndProperty types each step as a new PathValue (an object, an array or a value). It also returns the array it builds instead of re-reading it from current[name], and reads the schema's const through a typed local.
Inferred any Before After
lib/module/NormalModuleFactory.js 7 4
lib/config/cli.js 22 2

The 6 left are each a read of a public type that is any at its source: EffectBasic.value, the index signature of ObjectConfiguration and of JSONSchema4. Narrowing those would change the public types.

What kind of change does this PR introduce?

refactor

Did you add tests for your changes?

No new tests; the behaviour is unchanged. The rule-set config cases (59), the loaders and module config cases (437) and Cli.basictest.js pass. In Cli.basictest.js, createColors › simple (colors by default) also fails on main in a session with no TTY.

Does this PR introduce a breaking change?

No. types.d.ts is unchanged.

If relevant, what needs to be documented once your changes are merged or what have you already documented?

n/a

Use of AI

Claude Code wrote the change, using the Types Coverage tool's inferred-any list. It checked the change with yarn lint and the targeted config and CLI tests. The author reviewed it.

Generated by Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of command-line configuration values, including constants and paths that contain arrays.
    • Rule-based module settings now merge compatible object values more consistently, while loader selection behavior remains unchanged. These updates help configurations and build rules behave more predictably.

@changeset-bot

changeset-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ae7b839

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai Bot added area: config Options, defaults, validation (lib/config, schemas/) area: types types.d.ts, JSDoc annotations, hand-maintained declarations labels Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Types Coverage

Typed lines: 99.56% (195225 of 196083)

Escape hatch Base Head Change
EXPECTED_ANY 77 77 —
EXPECTED_OBJECT 47 47 —
EXPECTED_FUNCTION 3 3 —
unknown 141 143 🔴 +2
inferred any 151 128 🟢 −23

Inferred any counts the identifiers whose type TypeScript infers as any though no JSDoc names it, such as const map = new Map().

Changed by this pull request

File Typed lines EXPECTED_ANY EXPECTED_OBJECT EXPECTED_FUNCTION unknown inferred any
lib/config/cli.js 99.73% 1 1 2 (🟢 −20)
lib/module/NormalModuleFactory.js 98.20% 2 (🔴 +2) 4 (🟢 −3)
119 file(s) in lib/ and hot/ still use an escape hatch, infer `any` or have untyped lines
File Typed lines EXPECTED_ANY EXPECTED_OBJECT EXPECTED_FUNCTION unknown inferred any
lib/javascript/syntax-printer.js 99.95% 17 10 17 73
lib/javascript/syntax-parser.js 99.96% 1 37
lib/Compilation.js 99.63% 6 2 19
lib/Compiler.js 100.00% 5 2 6
lib/stats/StatsFactory.js 96.99% 4 1 6
lib/cache/PackFileCacheStrategy.js 99.23% 10
lib/hmr/JavascriptHotModuleReplacement.runtime.js 100.00% 1 7
lib/module/Module.js 98.77% 7
lib/module/NormalModule.js 99.45% 4 1 2
lib/util/cleverMerge.js 100.00% 1 6
lib/util/terminalColors.js 98.73% 1 6
lib/module/NormalModuleFactory.js 98.20% 2 (🔴 +2) 4 (🟢 −3)
lib/resolve/getResolveOptionsKey.js 100.00% 1 1 4
lib/serialization/SerializerMiddleware.js 100.00% 3 3
lib/debug/ProfilingPlugin.js 100.00% 1 4
lib/define/DefinePlugin.js 100.00% 1 4
lib/hmr/HotModuleReplacement.runtime.js 100.00% 5
lib/loaders/LoaderOptionsPlugin.js 90.63% 5
lib/serialization/ObjectMiddleware.js 99.79% 1 4
lib/cache/MemoryWithGcCachePlugin.js 100.00% 4
lib/config/cli.js 99.73% 1 1 2 (🟢 −20)
lib/config/normalization.js 99.14% 4
lib/graph/ModuleGraph.js 100.00% 3 1
lib/loaders/LoaderPlugin.js 99.41% 4
lib/performance/HotspotsPlugin.js 100.00% 4
lib/util/SortableSet.js 98.98% 4
lib/cache/MemoryCachePlugin.js 100.00% 3
lib/errors/WebpackError.js 97.14% 1 2
lib/util/WeakTupleMap.js 100.00% 3
lib/util/deprecation.js 99.24% 1 1 1
lib/asset/AssetModulesPlugin.js 99.38% 2
lib/cache/Cache.js 100.00% 2
lib/cache/IdleFileCachePlugin.js 100.00% 2
lib/config/defineConfig.js 100.00% 2
lib/css/syntax-parser.js 99.89% 2
lib/html/syntax-parser.js 99.95% 2
lib/javascript/JavascriptModulesPlugin.js 100.00% 2
lib/loaders/LoaderRunner.js 97.55% 2
lib/module/Parser.js 100.00% 2
lib/node/nodeConsole.js 100.00% 2
lib/stats/DefaultStatsFactoryPlugin.js 99.87% 1 1
lib/stats/DefaultStatsPrinterPlugin.js 99.88% 2
lib/util/SourceProcessor.js 100.00% 2
lib/util/comparators.js 100.00% 2
lib/util/serialization.js 98.68% 2
lib/util/validateSchema.js 100.00% 2
lib/MultiCompiler.js 99.74% 1
lib/context/ContextModuleFactory.js 100.00% 1
lib/css/CssModulesPlugin.js 100.00% 1
lib/dependencies/import/ImportParserPlugin.js 100.00% 1
lib/devtool/ModuleFilenameHelpers.js 99.47% 1
lib/dll/DllReferencePlugin.js 100.00% 1
lib/errors/NonErrorEmittedError.js 100.00% 1
lib/hmr/HotModuleReplacementPlugin.js 100.00% 1
lib/html/HtmlModulesPlugin.js 99.51% 1
lib/index.js 100.00% 1
lib/javascript/JavascriptParser.js 100.00% 1
lib/logging/Logger.js 100.00% 1
lib/logging/ProgressPlugin.js 99.80% 1
lib/module/ModuleSourceTypeConstants.js 100.00% 1
lib/optimize/ConcatenatedModule.js 99.89% 1
lib/optimize/TupleQueue.js 100.00% 1
lib/output/CopyPlugin.js 100.00% 1
lib/output/ManifestPlugin.js 100.00% 1
lib/performance/UnusedExternalsPlugin.js 95.35% 1
lib/rules/BasicEffectRulePlugin.js 100.00% 1
lib/rules/RuleSetCompiler.js 99.72% 1
lib/serialization/PlainObjectSerializer.js 100.00% 1
lib/serialization/SingleItemMiddleware.js 100.00% 1
lib/serialization/types.js 100.00% 1
lib/stats/DefaultStatsPresetPlugin.js 100.00% 1
lib/stats/StatsPrinter.js 99.11% 1
lib/template/Template.js 100.00% 1
lib/util/TupleSet.js 100.00% 1
lib/util/identifier.js 100.00% 1
lib/util/magicComment.js 100.00% 1
lib/util/makeSerializable.js 100.00% 1
lib/asset/AssetBytesParser.js 91.67%
lib/asset/AssetParser.js 96.15%
lib/asset/AssetSourceParser.js 91.67%
lib/config/validateSchema.js 94.67%
lib/css/CssGenerator.js 99.65%
lib/css/conventions.js 98.68%
lib/css/syntax-printer.js 99.73%
lib/dependencies/amd/AMDPlugin.js 99.31%
lib/dependencies/amd/AMDRuntimeModules.js 95.45%
lib/dependencies/commonjs/CommonJsExportsParserPlugin.js 99.79%
lib/dependencies/esm/ESMExportInitFragment.js 99.35%
lib/dependencies/helpers/processExportInfo.js 96.97%
lib/dependencies/html/HtmlEntryDependency.js 99.83%
lib/dependencies/import-meta/ImportMetaPlugin.js 99.63%
lib/devtool/SourceMapDevToolPlugin.js 99.78%
lib/errors/CacheEffectivenessWarning.js 93.75%
lib/externals/ExternalModule.js 99.87%
lib/fs/FileSystemInfo.js 99.92%
lib/graph/buildChunkGraph.js 99.88%
lib/hmr/HotModuleReplacementChunkVersionCheckRuntimeModule.js 87.50%
lib/hmr/HotModuleReplacementRuntimeModule.js 77.78%
lib/hmr/JavascriptHotModuleReplacementHelper.js 91.30%
lib/hmr/lazyCompilationBackend.js 99.07%
lib/html/HtmlGenerator.js 99.87%
lib/javascript/JavascriptMetaInfoPlugin.js 98.08%
lib/json/JsonParser.js 96.88%
lib/optimize/LazyBucketSortedSet.js 96.85%
lib/optimize/SideEffectsFlagPlugin.js 99.78%
lib/performance/UnusedDefinesPlugin.js 96.97%
lib/runtime/MakeDeferredNamespaceObjectRuntime.js 99.65%
lib/schemes/HttpUriPlugin.js 99.87%
lib/serialization/BinaryMiddleware.js 99.27%
lib/sharing/semver.js 99.54%
lib/template/RuntimeTemplate.js 99.95%
lib/util/async.js 97.62%
lib/util/binarySearchBounds.js 94.74%
lib/util/createMappings.js 98.45%
lib/util/globUtils.js 99.83%
lib/util/registerExternalSerializer.js 96.85%
lib/wasm-sync/WebAssemblyParser.js 98.94%
lib/wasm/AsyncWebAssemblyParser.js 97.83%
lib/webpack.js 98.62%

@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 416ba38 and ae7b839.

Files selected for processing: 2
  • lib/config/cli.js
  • lib/module/NormalModuleFactory.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The changes update type handling in CLI configuration parsing and NormalModuleFactory rule-effect processing. They also define how non-loader rule effects update module settings.

Changes: CLI configuration parsing

Layer / File(s) Summary
Schema values and path traversal types
lib/config/cli.js		 Reads schemaPart.const through a typed local and widens path-value types for array-valued intermediates and results. Existing [] path handling remains unchanged.

NormalModuleFactory rule effects

Layer / File(s) Summary
Loader results and module settings
lib/module/NormalModuleFactory.js		 Casts loader-effect results to LoaderItem without changing loader-selection conditions. Other object-valued effects merge with an existing non-null object setting; other values replace the setting.

Possibly related PRs

  • webpack/webpack#23021: Adds type annotations in cli.js and NormalModuleFactory.js, which are also updated here.

Suggested labels: area: config, area: types

Change: Refactor

Merge Risk: Minimal · up to ae7b8

The changes preserve existing CLI path handling and rule-effect merge behavior, with no merge-blocking risk identified.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title follows the required type(scope): subject format, and refactor is an allowed type. The branch prefix is not provided, so the type-to-branch match cannot be verified. Provide the branch name or prefix to confirm that it matches refactor.
Passed Passed checks: 3 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

This PR is packaged and the instant preview of its latest commit is available.

Install it locally:

  • npm
npm i -D webpack@https://pkg.pr.new/webpack@23034
  • yarn
yarn add -D webpack@https://pkg.pr.new/webpack@23034
  • pnpm
pnpm add -D webpack@https://pkg.pr.new/webpack@23034

@github-actions

github-actions Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Generated code size

Comparing base (416ba38) to head (ae7b839). Merging this pull request will not change the code webpack generates.

What moved Tests Assets Gzip Raw Test edit
Changed, test untouched 0 0 — — —
Changed, test edited 0 0 — — —
New 0 0 — — —
Deleted 0 0 — — —
Unchanged — 9854 — — —

Read Changed, test untouched first: the test is byte-identical on both sides, so webpack generated the difference. Changed, test edited moved partly because the test did — Test edit is how many bytes the test gained, and a bundle that grew by less is not a regression. New and Deleted are whole files, not deltas — a new asset was created, not grown, so it reads gray (⚪ added) — and adding tests cannot bury a real change. Gzip decides, because that is what users download; raw is the tiebreak, and brotli and zstd are per asset below.

Sample apps

No sample app changed size.

26 unchanged app(s)
App Gzip Gzip change Raw Raw change
library amd 1.38 KiB — 2.68 KiB —
library amd-require 1.38 KiB — 2.67 KiB —
library assign 1.38 KiB — 2.67 KiB —
library assign-properties 1.42 KiB — 2.80 KiB —
library commonjs 1.38 KiB — 2.66 KiB —
library commonjs-module 1.38 KiB — 2.67 KiB —
library commonjs-static 1.55 KiB — 3.54 KiB —
library commonjs2 1.38 KiB — 2.67 KiB —
library global 1.38 KiB — 2.66 KiB —
library jsonp 1.37 KiB — 2.66 KiB —
library module 1.21 KiB — 2.35 KiB —
library self 1.38 KiB — 2.66 KiB —
library system 1.41 KiB — 2.73 KiB —
library this 1.38 KiB — 2.66 KiB —
library umd 1.44 KiB — 2.86 KiB —
library umd2 1.44 KiB — 2.86 KiB —
library var 1.38 KiB — 2.67 KiB —
library window 1.38 KiB — 2.66 KiB —
node-ssr 96.36 KiB — 371.30 KiB —
node-ssr-esm 96.61 KiB — 372.00 KiB —
react-100 32.06 KiB — 150.15 KiB —
react-1k 73.05 KiB — 906.51 KiB —
react-1k-esm 72.54 KiB — 906.44 KiB —
react-5k 190.87 KiB — 4.08 MiB —
webworker 36.15 KiB — 93.71 KiB —
webworker-esm 35.67 KiB — 94.21 KiB —

No asset changed size.

No runtime gained or lost a runtime module.

Built test/configCases with the defaults a user gets, and the apps in test/sizeCoreReports (apps/): 2335 test(s), 9854 asset(s), 103 emitted nothing.

@codspeed

codspeed Bot commented Oct 31, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 22.05%

2 warnings, 1 note

⚠️ 117 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

ℹ️ 45 benchmarks have no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

❌ 1 regressed benchmark
✅ 350 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Memory benchmark "wasm-modules-async", scenario '{"name":"mode-production","mode":"production"}' 332.3 KB 426.3 KB -22.05%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing refactor/typed-rule-effects-and-cli (ae7b839) with main (416ba38)

Open in CodSpeed

@alexander-akait
alexander-akait merged commit 6aef449 into main Oct 31, 2026
54 checks passed
@alexander-akait
alexander-akait deleted the refactor/typed-rule-effects-and-cli branch October 31, 2026 11:06
@alexander-akait alexander-akait mentioned this pull request Oct 31, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Nov 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area: config Options, defaults, validation (lib/config, schemas/) area: types types.d.ts, JSDoc annotations, hand-maintained declarations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alexander-akait