Repository navigation
fix(esm): rehash entry chunks when a chunk they import changes - #22804
Merged
Merged
Conversation
An ESM entry chunk imports split chunks and its dependOn parents' chunks by hashed file name, but its hash ignored their hashes, so the cache served a stale render importing a file no longer emitted. Hash parent entry chunks first so their hashes are final. Fixes #22803
🦋 Changeset detectedLatest commit: e43ec7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
The title uses the required conventional-commit form and accurately describes the ESM entry-chunk rehashing change. The branch name is not provided, so the required match between the commit type and b… | Provide the branch name or confirm that its prefix is "fix". |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Linked Issues check Issue #22803requires ESM entry-chunk hashes to change when an imported initial chunk filename changes under filesystem caching.ModuleChunkFormatPluginnow adds the hashes of JavaScript chunks impo…Out of Scope Changes check The changes stay within issue #22803. TheModuleChunkFormatPluginhash update prevents cached ESM startup imports from referring to obsolete filenames. TheCompilation#createHashordering change c…Full details: Linked Issues check
-
Explanation
Issue
#22803requires ESM entry-chunk hashes to change when an imported initial chunk filename changes under filesystem caching.ModuleChunkFormatPluginnow adds the hashes of JavaScript chunks imported during startup.Compilation#createHashorders dependent entry chunks after parent entry chunks. The added filesystem-cache watch case covers runtime chunk and inlined runtime modes,realContentHashmodes, hash types, anddependOn; it checks imports against current emitted assets and requires no compilation errors. These changes implement the linked issue's coding and test requirements.
Full details: Out of Scope Changes check
-
Explanation
The changes stay within issue
#22803. TheModuleChunkFormatPluginhash update prevents cached ESM startup imports from referring to obsolete filenames. TheCompilation#createHashordering change covers the relateddependOnentry dependency described by the PR. The fixture changes, automated cache test, and changeset support these objectives. No unrelated behavior is established by the reviewed evidence.
-
Full details: Title check
-
Explanation
The title uses the required conventional-commit form and accurately describes the ESM entry-chunk rehashing change. The branch name is not provided, so the required match between the commit type and branch prefix cannot be verified.
Resolution
Provide the branch name or confirm that its prefix is "fix".
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
github-actions
Bot
added
the
area: runtime
Contributor
|
This PR is packaged and the instant preview of its latest commit is available. Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@22804
yarn add -D webpack@https://pkg.pr.new/webpack@22804
pnpm add -D webpack@https://pkg.pr.new/webpack@22804 |
Contributor
Types CoverageCoverage after merging fix/esm-entry-imported-chunk-hash into main will be
Coverage Report |
Contributor
Generated code sizeComparing base (
Read 1 asset(s) changed size, test untouched
No runtime gained or lost a runtime module. Built |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22804 +/- ##
=======================================
Coverage 96.50% 96.50%
=======================================
Files 778 778
Lines 137994 138017 +23
Branches 46923 46928 +5
=======================================
+ Hits 133176 133199 +23
Misses 4818 4818
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will regress 1 benchmark
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
|
markharding
pushed a commit
to futo-org/Harbor
that referenced
this pull request
Oct 27, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [webpack](https://github.com/webpack/webpack) | [`5.112.0` → `5.112.2`](https://renovatebot.com/diffs/npm/webpack/5.112.0/5.112.2) |  |  | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/99) for more information. --- ### Release Notes <details> <summary>webpack/webpack (webpack)</summary> ### [`v5.112.2`](https://github.com/webpack/webpack/blob/HEAD/CHANGELOG.md#51122) [Compare Source](webpack/webpack@v5.112.1...v5.112.2) ##### Patch Changes - Reduce repeated scans when concatenating imported modules. (by [@​xiaoxiaojx](https://github.com/xiaoxiaojx) in [#​22865](webpack/webpack#22865)) - Avoid allocating CSS module sets for single-group chunks. (by [@​xiaoxiaojx](https://github.com/xiaoxiaojx) in [#​22866](webpack/webpack#22866)) - Return the value of every module type loaded with `importModule()`. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22869](webpack/webpack#22869)) ### [`v5.112.1`](https://github.com/webpack/webpack/blob/HEAD/CHANGELOG.md#51121) [Compare Source](webpack/webpack@v5.112.0...v5.112.1) ##### Patch Changes - Rebuild a lazy barrel in watch when what it defers changes, and keep the imports and re-exports it still runs. (by [@​aryanraj45](https://github.com/aryanraj45) in [#​22699](webpack/webpack#22699)) - Rebuild under `cacheUnaffected` a module whose re-export target goes or returns. (by [@​aryanraj45](https://github.com/aryanraj45) in [#​22749](webpack/webpack#22749)) - Fix "Self-reference dependency has unused export name" for CommonJS namespace re-exports. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22791](webpack/webpack#22791)) - Fix `exportType: "style"` CSS modules throwing outside the runtime chunk. (by [@​lazerg](https://github.com/lazerg) in [#​22833](webpack/webpack#22833)) - Fix crash when a CSS module with `exportType: "style"` imports an ignored stylesheet. (by [@​codeXsidd](https://github.com/codeXsidd) in [#​22846](webpack/webpack#22846)) - Keep empty process environment variables that `.env` files don't define in `DotenvPlugin`. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22794](webpack/webpack#22794)) - Rehash an ESM entry chunk when a chunk it imports by file name changes. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22804](webpack/webpack#22804)) - Handle a NUL inside an HTML CDATA section the way the parsing spec does. (by [@​dependabot](https://github.com/apps/dependabot) in [#​22811](webpack/webpack#22811)) - Keep module exports live across chunks, runtimes, HMR and eval, sparing globals. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22733](webpack/webpack#22733)) - Await asynchronous modules that `ProvidePlugin` injects into ES modules. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22728](webpack/webpack#22728)) - Keep a resolve that ends after the compiler closed from throwing. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22795](webpack/webpack#22795)) - Preserve string names passed to SharedWorker constructors. (by [@​bjohansebas](https://github.com/bjohansebas) in [#​22770](webpack/webpack#22770)) - Preserve string contents when extracting source map comments. (by [@​bjohansebas](https://github.com/bjohansebas) in [#​22768](webpack/webpack#22768)) - Scope strict-mode, async and generator block function declarations to their block. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22800](webpack/webpack#22800)) - Preserve raw dotenv values when reusing cached environment files. (by [@​Eshiv-Pandey](https://github.com/Eshiv-Pandey) in [#​22787](webpack/webpack#22787)) - Preserve assigned or patched built-ins, conversions and pattern targets. (by [@​aryanraj45](https://github.com/aryanraj45) in [#​22761](webpack/webpack#22761)) - Keep globals a `globalThis` write replaces, and `slice` on a patched array. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22862](webpack/webpack#22862)) - Skip HTML script tags for shared chunks that emit no JavaScript. (by [@​bjohansebas](https://github.com/bjohansebas) in [#​22779](webpack/webpack#22779)) - Keep the digits Firefox lays out a minified CSS percentage with. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22718](webpack/webpack#22718)) - Reject a second `srcset` descriptor after a `0x` density descriptor. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22741](webpack/webpack#22741)) - Minify JavaScript faster, folding string methods on constants and `x -= 1`. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22823](webpack/webpack#22823)) - Shorten minified JavaScript, and keep it running like its source. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22717](webpack/webpack#22717)) - Drop more unused functions, arguments, calls, global reads and variable copies when minifying JavaScript. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22789](webpack/webpack#22789)) - Minify JavaScript smaller where swc does, and fold a function's `length` right. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22826](webpack/webpack#22826)) - Reduce JavaScript output size where oxc or swc produce smaller output. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22829](webpack/webpack#22829)) - Update watchpack to 2.6.3 and rebuild on a `node_modules` created mid-build. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22743](webpack/webpack#22743)) - Support `concatenateModules` with `cacheUnaffected`. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22746](webpack/webpack#22746)) - Update schema-utils to 4.8.1. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22774](webpack/webpack#22774)) - Keep CSS fallbacks, vendor overrides, `oklch()` hues and HTML elements. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22753](webpack/webpack#22753)) - Validate `CleanPlugin` and `DotenvPlugin` options with a precompiled check, so valid options no longer compile their schema at startup. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22758](webpack/webpack#22758)) - Speed up startup and CSS minification, sharing the compile cache with workers. (by [@​xiaoxiaojx](https://github.com/xiaoxiaojx) in [#​22706](webpack/webpack#22706)) - Use precise, generic types for modules, parsers, generators, stats and loaders. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22731](webpack/webpack#22731)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - "before 9am on tuesday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNzUuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjE3NS4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://code.futo.org/harbor/harbor/pulls/2035
markharding
pushed a commit
to futo-org/Harbor
that referenced
this pull request
Oct 29, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [webpack](https://github.com/webpack/webpack) | [`5.112.0` → `5.112.2`](https://renovatebot.com/diffs/npm/webpack/5.112.0/5.112.2) |  |  | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/99) for more information. --- ### Release Notes <details> <summary>webpack/webpack (webpack)</summary> ### [`v5.112.2`](https://github.com/webpack/webpack/blob/HEAD/CHANGELOG.md#51122) [Compare Source](webpack/webpack@v5.112.1...v5.112.2) ##### Patch Changes - Reduce repeated scans when concatenating imported modules. (by [@​xiaoxiaojx](https://github.com/xiaoxiaojx) in [#​22865](webpack/webpack#22865)) - Avoid allocating CSS module sets for single-group chunks. (by [@​xiaoxiaojx](https://github.com/xiaoxiaojx) in [#​22866](webpack/webpack#22866)) - Return the value of every module type loaded with `importModule()`. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22869](webpack/webpack#22869)) ### [`v5.112.1`](https://github.com/webpack/webpack/blob/HEAD/CHANGELOG.md#51121) [Compare Source](webpack/webpack@v5.112.0...v5.112.1) ##### Patch Changes - Rebuild a lazy barrel in watch when what it defers changes, and keep the imports and re-exports it still runs. (by [@​aryanraj45](https://github.com/aryanraj45) in [#​22699](webpack/webpack#22699)) - Rebuild under `cacheUnaffected` a module whose re-export target goes or returns. (by [@​aryanraj45](https://github.com/aryanraj45) in [#​22749](webpack/webpack#22749)) - Fix "Self-reference dependency has unused export name" for CommonJS namespace re-exports. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22791](webpack/webpack#22791)) - Fix `exportType: "style"` CSS modules throwing outside the runtime chunk. (by [@​lazerg](https://github.com/lazerg) in [#​22833](webpack/webpack#22833)) - Fix crash when a CSS module with `exportType: "style"` imports an ignored stylesheet. (by [@​codeXsidd](https://github.com/codeXsidd) in [#​22846](webpack/webpack#22846)) - Keep empty process environment variables that `.env` files don't define in `DotenvPlugin`. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22794](webpack/webpack#22794)) - Rehash an ESM entry chunk when a chunk it imports by file name changes. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22804](webpack/webpack#22804)) - Handle a NUL inside an HTML CDATA section the way the parsing spec does. (by [@​dependabot](https://github.com/apps/dependabot) in [#​22811](webpack/webpack#22811)) - Keep module exports live across chunks, runtimes, HMR and eval, sparing globals. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22733](webpack/webpack#22733)) - Await asynchronous modules that `ProvidePlugin` injects into ES modules. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22728](webpack/webpack#22728)) - Keep a resolve that ends after the compiler closed from throwing. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22795](webpack/webpack#22795)) - Preserve string names passed to SharedWorker constructors. (by [@​bjohansebas](https://github.com/bjohansebas) in [#​22770](webpack/webpack#22770)) - Preserve string contents when extracting source map comments. (by [@​bjohansebas](https://github.com/bjohansebas) in [#​22768](webpack/webpack#22768)) - Scope strict-mode, async and generator block function declarations to their block. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22800](webpack/webpack#22800)) - Preserve raw dotenv values when reusing cached environment files. (by [@​Eshiv-Pandey](https://github.com/Eshiv-Pandey) in [#​22787](webpack/webpack#22787)) - Preserve assigned or patched built-ins, conversions and pattern targets. (by [@​aryanraj45](https://github.com/aryanraj45) in [#​22761](webpack/webpack#22761)) - Keep globals a `globalThis` write replaces, and `slice` on a patched array. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22862](webpack/webpack#22862)) - Skip HTML script tags for shared chunks that emit no JavaScript. (by [@​bjohansebas](https://github.com/bjohansebas) in [#​22779](webpack/webpack#22779)) - Keep the digits Firefox lays out a minified CSS percentage with. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22718](webpack/webpack#22718)) - Reject a second `srcset` descriptor after a `0x` density descriptor. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22741](webpack/webpack#22741)) - Minify JavaScript faster, folding string methods on constants and `x -= 1`. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22823](webpack/webpack#22823)) - Shorten minified JavaScript, and keep it running like its source. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22717](webpack/webpack#22717)) - Drop more unused functions, arguments, calls, global reads and variable copies when minifying JavaScript. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22789](webpack/webpack#22789)) - Minify JavaScript smaller where swc does, and fold a function's `length` right. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22826](webpack/webpack#22826)) - Reduce JavaScript output size where oxc or swc produce smaller output. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22829](webpack/webpack#22829)) - Update watchpack to 2.6.3 and rebuild on a `node_modules` created mid-build. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22743](webpack/webpack#22743)) - Support `concatenateModules` with `cacheUnaffected`. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22746](webpack/webpack#22746)) - Update schema-utils to 4.8.1. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22774](webpack/webpack#22774)) - Keep CSS fallbacks, vendor overrides, `oklch()` hues and HTML elements. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22753](webpack/webpack#22753)) - Validate `CleanPlugin` and `DotenvPlugin` options with a precompiled check, so valid options no longer compile their schema at startup. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22758](webpack/webpack#22758)) - Speed up startup and CSS minification, sharing the compile cache with workers. (by [@​xiaoxiaojx](https://github.com/xiaoxiaojx) in [#​22706](webpack/webpack#22706)) - Use precise, generic types for modules, parsers, generators, stats and loaders. (by [@​alexander-akait](https://github.com/alexander-akait) in [#​22731](webpack/webpack#22731)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - "before 9am on tuesday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNzUuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjE3NS4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://code.futo.org/harbor/harbor/pulls/2035
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22803.
With
output.module, an entry chunk imports other chunks by their hashed file names, but its own hash ignored their hashes. When only an imported chunk changed, the cache served the old render, which imports a file that is no longer emitted. There were two causes:ModuleChunkFormatPluginhashed only the ids of the chunks it imports. It now also hashes their hashes. This covers both a separate runtime chunk and the runtime inlined in the entry chunk (runtimeChunk: false, the default), which the patch in the issue misses.dependOn, a child entry chunk imports its parent's entry chunk, but entry chunks were hashed in id order.Compilation#createHashnow hashes an entry chunk after the entry chunks of its parent entrypoints.CommonJS output only
requires the runtime by file name (covered by #19439), so it is unchanged.Before and after, using the reproducer from the issue (second build, after
lib.jschanges):Cost, measured on a stress fixture (300 ESM entries in
dependOnchains of 10, shared split chunks, async imports), 6 builds per process,--cpu-profat 100 µs:runtimeChunk: "single"runtimeChunk: falseModule, error, warning and asset counts are unchanged, and every emitted file name is identical to
mainfor ESM and CommonJS.What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes:
test/watchCases/cache/esm-entry-imported-chunk-hash/. It runs four compilers (shared runtime chunk or inlined runtime,realContentHashon or off,[contenthash]or[chunkhash]) with the filesystem cache, plus adependOnchild that sorts before its parent. It checks every import against the current build's assets. It fails without either half of the fix.Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
n/a
Use of AI
Claude Code reproduced the issue, found the second (
dependOn) cause, wrote the fix and the test, and measured CPU and memory. The requester reviewed the work.Generated by Claude Code
Summary by CodeRabbit