Repository navigation
refactor(types): precise stats, loader, fragment and serialization types - #22762
Conversation
|
| Name | Type |
|---|---|
| webpack | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
github-actions
Bot
added
area: parser
|
This PR is packaged and the instant preview is available (58ecc95). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@58ecc95
yarn add -D webpack@https://pkg.pr.new/webpack@58ecc95
pnpm add -D webpack@https://pkg.pr.new/webpack@58ecc95 |
Types CoverageCoverage after merging refactor/stats-loader-generics into main will be
Coverage Report |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Change: Refactor Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
The title uses the required Conventional Commit form and a valid type: refactor(types): precise stats, loader, fragment and serialization types. The branch prefix is not provided, so it is not possi… |
Provide the branch name or confirm that its prefix is refactor. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Title check
-
Explanation
The title uses the required Conventional Commit form and a valid type:
refactor(types): precise stats, loader, fragment and serialization types. The branch prefix is not provided, so it is not possible to verify thatrefactormatches the branch prefix.Resolution
Provide the branch name or confirm that its prefix is
refactor.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 ast-grep (0.45.3)
-
lib/javascript/syntax-printer.js
-
ast-grep timed out on this file
-
🔧 ESLint
-
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
lib/javascript/syntax-printer.js
-
ESLint failed to execute (timeout).
lib/loaders/LoaderRunner.js
-
ESLint skipped: the matched ESLint configuration already failed (timeout).
lib/module/Module.js
-
ESLint skipped: the matched ESLint configuration already failed (timeout).
- 13 others
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Generated code sizeComparing base (
Read No asset changed size. No runtime gained or lost a runtime module. Built |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22762 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 778 778
Lines 137320 137324 +4
Branches 46550 46551 +1
=======================================
+ Hits 132488 132500 +12
+ Misses 4832 4824 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Continues #22752: replaces
anywith real types or generics, keeping existing callers compiling.EXPECTED_ANYinlib/goes from 118 to 97.foroverloads. Plugin keys fall back to the old open type.dataand loader entry options are generic. Runner results are typed as content, source map and additional data.anyor the generator's context.JSONParseError, minify options, tuple cache keys, lazy runtime modules,cleverMergeand the lazy serialization slot.What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
No new tests; types are checked by
yarn lint:types*.test/unitCases/LoaderRunner.unittest.jsnow reads the typed result through a small helper.Does this PR introduce a breaking change?
No. A few type-only fixes can surface errors in code that was already wrong at runtime:
chunkInitFragments.addLazyRuntimeModule(nowT extends object).formatminify option the minifier rejects at runtime.Optional
webpackASTon loader additional data only loosens a type.If relevant, what needs to be documented once your changes are merged or what have you already documented?
n/a
Use of AI
Claude Code wrote the type changes. It checked them with
yarn lint, alllint:types*projects, compile probes againsttypes.d.tsand targeted tests. The author reviewed the changes.Generated by Claude Code
Summary by CodeRabbit