Repository navigation
fix(css): read the at-keyword through the shared node path helper - #22591
Conversation
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR is packaged and the instant preview is available (9d0a8fe). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@9d0a8fe
yarn add -D webpack@https://pkg.pr.new/webpack@9d0a8fe
pnpm add -D webpack@https://pkg.pr.new/webpack@9d0a8fe |
Types CoverageCoverage after merging fix/css-at-keyword-path into main will be
Coverage Report |
Generated code sizeComparing base ( Warning The baseline is
Read 34 asset(s) changed size, test untouched, biggest 20 by raw or gzip change
1 asset(s) changed size, test edited
No runtime gained or lost a runtime module. Built |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22591 +/- ##
==========================================
+ Coverage 95.54% 96.19% +0.65%
==========================================
Files 774 774
Lines 128230 128374 +144
Branches 42484 42525 +41
==========================================
+ Hits 122514 123489 +975
+ Misses 5716 4885 -831
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
mainis red: minifying CSS throwsTypeError: path.atKeyword is not a function. #22569 removedpath.atKeyword()and switched every call site to_atKeywordOf(), and #22513 merged right after with one more call to the removed method. This failslint(type check),basic,unitandinvariantsonmain, and so skips the benchmarks on every open PR.CssSyntax.unittest.jscss minimize-vendor-prefixes,minimize-web-corpusmain(8953192)unit)Neither commit is in a release, so there is no changeset.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
No, the existing
test/unitCases/CssSyntax.unittest.jsand thecss/minimize-*config cases already cover it and fail onmain.Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
n/a
Use of AI
Claude Code traced the CI failure on
mainto the conflicting commits, made the one-line fix and ran the failing tests and lint. A human reviews the change.🤖 Generated with Claude Code
https://claude.ai/code/session_017TkBWTk3wcyUcJYDp5ZhaP
Generated by Claude Code