Skip to content

docs(pull-requests): say that nothing to report means an empty answer - #22404

Merged
alexander-akait merged 1 commit into
mainfrom
docs/silent-wake-needs-no-message
Oct 2, 2026
Merged

alexander-akait merged 1 commit into
mainfrom
docs/silent-wake-needs-no-message

Conversation

@alexander-akait

@alexander-akait alexander-akait commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Summary

docs/pull-requests.md already says a wake that changes nothing ends with no message, and lists partial-upload coverage percentages and bot echoes among what never to narrate. One gap let it be followed in letter and missed in spirit: where the harness asks for visible output on an otherwise silent turn, the easiest answer is a line saying the wake needed no action — which is the narration the rule forbids.

On #22397 that produced about twenty such lines over one run, reporting codecov recomputing 77% → 94% → 96% while its uploads landed. Each was accurate and none was worth reading.

Two sentences close it, next to the rule they qualify:

**Nothing to report means an empty answer**, including where the harness asks
for visible output: return nothing rather than the status line that request
invites. A line saying a wake needed no action is the narration this forbids,
and twenty of them over one run read as noise around the wake that did.

What kind of change does this PR introduce?

docs

Did you add tests for your changes?

n/a — prose in docs/, which no suite reads.

Does this PR introduce a breaking change?

No.

If relevant, what needs to be documented once your changes are merged or what have you already documented?

This is the documentation. Nothing for the website: docs/ is not published, so there is no changeset either.

Use of AI

Claude Code wrote this, and the gap is one it fell into on #22397 — it reported each intermediate coverage recompute instead of staying silent. I asked it to write the rule down rather than rely on remembering.


Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that when a wake requires no action, the response should be empty—even if visible output is requested. A status line indicating that no action was needed should not be sent. This guidance makes the expected response clearer for no-action situations.

The rule that a wake changing nothing ends with no message left one gap: a
harness asking for visible output invites a line saying the wake needed no
action, which is the narration the rule forbids. Over a run of twenty such
wakes those lines bury the one that mattered.
@changeset-bot

changeset-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8b97b17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

This PR is packaged and the instant preview is available (adb64f6).

Install it locally:

  • npm
npm i -D webpack@https://pkg.pr.new/webpack@adb64f6
  • yarn
yarn add -D webpack@https://pkg.pr.new/webpack@adb64f6
  • pnpm
pnpm add -D webpack@https://pkg.pr.new/webpack@adb64f6

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (2)
docs/pull-requests.md — configured
AGENTS.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: webpack/webpack/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 35c378db-5908-4dd1-b2bb-e848e43aaf9d

📥 Commits

Reviewing files that changed from the base of the PR and between 9fd4df5 and 8b97b17.

📒 Files selected for processing (1)
  • docs/pull-requests.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The pull-request guidance now specifies what to return when a wake needs no action, including when visible output is requested.

Changes

No-action wake guidance

Layer / File(s) Summary
No-action response instructions
docs/pull-requests.md
The guidance says to return no response when a wake needs no action, even if visible output is requested. It also says not to send a no-action status line.

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to 8b97b

The change clarifies when no-action wakes should produce no message, while preserving reporting for actionable decisions and artifacts. No concrete merge risk is established.

Architecture Summary

Architecture risk: 🔵 Low · up to 8b97b

The change affects 1 system.

Changed systems: docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/pull-requests.md: Adds guidance to return no response when a wake needs no action, including when visible output is requested, and not to send a no-action status line.
🚥 Pre-merge checks | ✅ 3 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title uses valid Conventional Commit syntax, uses the allowed type docs, and accurately describes the documentation change. The branch prefix is not provided, so the required type-prefix match c… Provide the branch name or branch prefix, then confirm that it starts with docs.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title uses valid Conventional Commit syntax, uses the allowed type docs, and accurately describes the documentation change. The branch prefix is not provided, so the required type-prefix match cannot be verified.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Types Coverage

Coverage after merging docs/silent-wake-needs-no-message into main will be
95.86%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
bin
   webpack.js98.82%100%100%98.82%103
declarations
   WebpackOptions.ts99.94%100%100%99.94%4152
examples
   build-common.js100%100%100%100%
   buildAll.js100%100%100%100%
   examples.js100%100%100%100%
   template-common.js98.21%100%100%98.21%72
examples/custom-javascript-parser
   test.filter.js100%100%100%100%
examples/custom-javascript-parser/internals
   acorn-parse.js100%100%100%100%
   meriyah-parse.js100%100%100%100%
   oxc-parse.js100%100%100%100%
examples/markdown
   webpack.config.mjs100%100%100%100%
examples/module-federation
   test.filter.js100%100%100%100%
examples/reexport-components
   test.filter.js100%100%100%100%
examples/ssr
   test.filter.js100%100%100%100%
examples/typescript
   test.filter.js100%100%100%100%
examples/typescript-non-erasable
   test.filter.js50%100%100%50%5
examples/virtual-modules
   test.filter.js100%100%100%100%
examples/wasm-bindgen-esm
   test.filter.js100%100%100%100%
examples/wasm-complex
   test.filter.js100%100%100%100%
examples/wasm-emscripten
   test.filter.js100%100%100%100%
examples/wasm-simple
   test.filter.js100%100%100%100%
examples/wasm-simple-source-phase
   test.filter.js100%100%100%100%
lib
   Chunk.js100%100%100%100%
   Compilation.js98.59%100%100%98.59%1757, 2078, 2085, 2093, 2115, 2118, 23, 3051, 3530–3531, 3563, 4152, 4156, 4283, 4304, 4429, 4466, 4473, 4526–4527, 4531, 4536, 4552–4553, 4567–4568, 4573–4574, 5097, 5123, 5953, 5970, 5988, 6004, 6019, 6044, 6047, 6415, 6418–6419, 6424, 6439, 6522, 6546, 6660, 837–838
   Compiler.js98.81%100%100%98.81%1116, 1153, 1156, 1336–1337, 1345, 848, 934, 975
   Dependency.js100%100%100%100%
   DependencyTemplate.js100%100%100%100%
   EntryPlugin.js100%100%100%100%
   Entrypoint.js100%100%100%100%
   ExternalsPlugin.js100%100%100%100%
   FileSystemInfo.js100%100%100%100%
   InitFragment.js100%100%100%100%
   LibraryTemplatePlugin.js100%100%100%100%
   ModuleFilenameHelpers.js100%100%100%100%
   ModuleNotFoundError.js100%100%100%100%
   MultiCompiler.js98.88%100%100%98.88%460, 532, 719, 784
   NormalModule.js100%100%100%100%
   NullFactory.js100%100%100%100%
   ProgressPlugin.js100%100%100%100%
   RawModule.js100%100%100%100%
   RequestShortener.js100%100%100%100%
   SingleEntryPlugin.js100%100%100%100%
   WebpackError.js100%100%100%100%
   index.js99.77%100%100%99.77%206
   webpack.js97.84%100%100%97.84%278, 300, 302
lib/asset
   AssetBytesGenerator.js100%100%100%100%
   AssetBytesParser.js100%100%100%100%
   AssetGenerator.js100%100%100%100%
   AssetModule.js100%100%100%100%
   AssetModulesPlugin.js98.15%100%100%98.15%338, 362, 365, 495, 57, 62
   AssetParser.js100%100%100%100%
   AssetSourceGenerator.js100%100%100%100%
   AssetSourceParser.js100%100%100%100%
   RawDataUrlModule.js100%100%100%100%
   WebManifestGenerator.js100%100%100%100%
   WebManifestParser.js100%100%100%100%
lib/async-modules
   AsyncModuleHelpers.js100%100%100%100%
   AwaitDependenciesInitFragment.js100%100%100%100%
   InferAsyncModulesPlugin.js100%100%100%100%
   isGeneratorLowered.js100%100%100%100%
lib/bun
   BunTargetPlugin.js100%100%100%100%
lib/cache
   AddBuildDependenciesPlugin.js100%100%100%100%
   AddManagedPathsPlugin.js100%100%100%100%
   Cache.js96.49%100%100%96.49%10, 104
   CacheFacade.js100%100%100%100%
   IdleFileCachePlugin.js97.92%100%100%97.92%75, 87, 95
   MemoryCachePlugin.js92%100%100%92%33, 42
   MemoryWithGcCachePlugin.js93.42%100%100%93.42%106, 120–121, 130, 88
   PackFileCacheStrategy.js96.54%100%100%96.54%1304, 1404, 1408, 1470, 1716, 1800, 1823, 1853, 682, 701, 711–713, 715, 731–732, 737, 740, 742, 747, 752, 777, 783, 817, 823, 829, 834, 845, 854, 859–860, 862, 879, 885–886, 888
   ResolverCachePlugin.js100%100%100%100%
   getLazyHashedEtag.js100%100%100%100%
   mergeEtags.js100%100%100%100%
lib/config
   OptionsApply.js100%100%100%100%
   PlatformPlugin.js100%100%100%100%
   WebpackOptionsApply.js100%100%100%100%
   WebpackOptionsDefaulter.js100%100%100%100%
   browserslistTargetHandler.js100%100%100%100%
   cli.js98.61%100%100%98.61%116, 546, 578, 628, 9
   defaults.js99.44%100%100%99.44%1623–1625, 1633, 283, 286, 291, 295
   defineConfig.js100%100%100%100%
   getClaimedAssetTypes.js100%100%100%100%
   normalization.js99.12%100%100%99.12%279–280, 346, 361
   target.js100%100%100%100%
   validateSchema.js94.67%100%100%94.67%100, 87, 89, 98
lib/container
   ContainerEntryDependency.js100%100%100%100%
   ContainerEntryModule.js100%100%100%100%
   ContainerEntryModuleFactory.js100%100%100%100%
   ContainerExposedDependency.js100%100%100%100%
   ContainerPlugin.js100%100%100%100%
   ContainerReferencePlugin.js100%100%100%100%
   FallbackDependency.js100%100%100%100%
   FallbackItemDependency.js100%100%100%100%
   FallbackModule.js100%100%100%100%
   FallbackModuleFactory.js100%100%100%100%
   HoistContainerReferencesPlugin.js100%100%100%100%
   ModuleFederationPlugin.js100%100%100%100%
   RemoteModule.js100%100%100%100%
   RemoteRuntimeModule.js100%100%100%100%
   RemoteToExternalDependency.js100%100%100%100%
   declaredRemotes.js100%100%100%100%
   moduleFederationHooks.js100%100%100%100%
   options.js100%100%100%100%
lib/context
   ContextExclusionPlugin.js100%100%100%100%
   ContextModule.js99.88%100%100%99.88%1494
   ContextModuleFactory.js95.66%100%100%95.66%230, 257, 276, 280–281, 289, 465, 486, 491, 532, 541, 543, 547, 550, 556–557
   ContextReplacementPlugin.js100%100%100%100%
lib/css
   CssGenerator.js99.47%100%100%99.47%1085, 136, 842
   CssInjectStyleRuntimeModule.js100%100%100%100%
   CssLoadingRuntimeModule.js100%100%100%100%
   CssModule.js83.16%100%100%83.16%197, 202–210, 212–217
   CssModulesPlugin.js99.86%100%100%99.86%886
   CssParser.js99.47%100%100%99.47%1037, 1068, 2307, 24, 2941, 2944, 2950, 2991, 2994, 3033, 3036, 3373, 4907, 4910, 921
   CssServerStylesRuntimeModule.js100%100%100%100%
   conventions.js98.65%100%100%98.65%93
   cssMinify.js96.30%100%100%96.30%127, 136
   data.js99.83%100%100%99.83%229, 4131
   syntax-parser.js99.73%100%100%99.73%10239–10240, 10277, 10458, 10504, 12711, 13209, 13562, 15246, 2411, 3110, 3112, 3117, 3136, 3881, 3887, 7170, 7208, 7215, 9704–9705
   syntax-printer.js99.29%100%100%99.29%2336–2337, 2339–2340, 2342–2343, 2348, 2609–2612, 3396, 3529, 3638, 4124, 4379, 5163, 626
   syntax.js100%100%100%100%
   topologicalSort.js100%100%100%100%
lib/debug
   ProfilingPlugin.js96.22%100%100%96.22%169, 425, 554, 561, 570, 574, 583, 588, 594, 599, 92
lib/define
   DefinePlugin.js98.85%100%100%98.85%1495, 268–269, 285, 304, 378, 936, 938, 943, 967
   DotenvPlugin.js98.07%100%100%98.07%391, 439, 452–453
   EnvironmentPlugin.js97.14%100%100%97.14%49
lib/deno
   DenoTargetPlugin.js100%100%100%100%
lib/dependencies
   ConstDependency.js100%100%100%100%
   ContextElementDependency.js100%100%100%100%
   NullDependency.js100%100%100%100%
lib/dependencies/amd
   AMDDefineDependency.js100%100%100%100%
   AMDDefineDependencyParserPlugin.js100%100%100%100%
   AMDPlugin.js99.31%100%100%99.31%54
   AMDRequireArrayDependency.js100%100%100%100%
   AMDRequireContextDependency.js100%100%100%100%
   AMDRequireDependenciesBlock.js100%100%100%100%
   AMDRequireDependenciesBlockParserPlugin.js100%100%100%100%
   AMDRequireDependency.js100%100%100%100%
   AMDRequireItemDependency.js100%100%100%100%
   AMDRuntimeModules.js95.45%100%100%95.45%

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.07%. Comparing base (9fd4df5) to head (8b97b17).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22404   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         771      771           
  Lines      122546   122546           
  Branches    39391    39391           
=======================================
  Hits       117742   117742           
  Misses       4804     4804           
Flag Coverage Δ
css-parsing 25.50% <ø> (ø)
html5lib 27.19% <ø> (ø)
integration 83.82% <ø> (ø)
minify-corpora 77.95% <ø> (ø)
syntax-equivalence 78.79% <ø> (ø)
test262 54.65% <ø> (ø)
unit 77.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Generated code size

Comparing base (9fd4df5) to head (8b97b17). Merging this pull request will not change the code webpack generates.

What moved Tests Assets Gzip Raw Test edit
Changed, test untouched 0 0 — — —
Changed, test edited 0 0 — — —
New 0 0 — — —
Deleted 0 0 — — —
Unchanged — 8312 — — —

Read Changed, test untouched first: the test is byte-identical on both sides, so webpack generated the difference. Changed, test edited moved partly because the test did — Test edit is how many bytes the test gained, and a bundle that grew by less is not a regression. New and Deleted are whole files, not deltas — a new asset was created, not grown, so it reads gray (⚪ added) — and adding tests cannot bury a real change. Gzip decides, because that is what users download; raw is the tiebreak, and brotli and zstd are per asset below.

No asset changed size.

No runtime gained or lost a runtime module.

Built test/configCases with the defaults a user gets: 2299 test(s), 8312 asset(s), 96 emitted nothing.

@codspeed

codspeed Bot commented Oct 2, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 33.85%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 400 untouched benchmarks
⏩ 6 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Memory unit benchmark "css-parser-tailwind-unit", readToken (min) 19.1 KB 13.8 KB +38.28%
⚡ Memory benchmark "cache-filesystem", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 1.4 MB 1.1 MB +29.55%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing docs/silent-wake-needs-no-message (8b97b17) with main (9fd4df5)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@alexander-akait
alexander-akait merged commit adb64f6 into main Oct 2, 2026
71 checks passed
@alexander-akait
alexander-akait deleted the docs/silent-wake-needs-no-message branch October 2, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant