Repository navigation
docs(pull-requests): say that nothing to report means an empty answer - #22404
Conversation
The rule that a wake changing nothing ends with no message left one gap: a harness asking for visible output invites a line saying the wake needed no action, which is the narration the rule forbids. Over a run of twenty such wakes those lines bury the one that mattered.
|
|
This PR is packaged and the instant preview is available (adb64f6). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@adb64f6
yarn add -D webpack@https://pkg.pr.new/webpack@adb64f6
pnpm add -D webpack@https://pkg.pr.new/webpack@adb64f6 |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (2)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: webpack/webpack/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe pull-request guidance now specifies what to return when a wake needs no action, including when visible output is requested. ChangesNo-action wake guidance
Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to The change clarifies when no-action wakes should produce no message, while preserving reporting for actionable decisions and artifacts. No concrete merge risk is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 3 | ❓ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
Full details: Title checkExplanation The title uses valid Conventional Commit syntax, uses the allowed type
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Types CoverageCoverage after merging docs/silent-wake-needs-no-message into main will be
Coverage Report |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22404 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 771 771
Lines 122546 122546
Branches 39391 39391
=======================================
Hits 117742 117742
Misses 4804 4804
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Generated code sizeComparing base (
Read No asset changed size. No runtime gained or lost a runtime module. Built |
Merging this PR will improve performance by 33.85%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Memory | unit benchmark "css-parser-tailwind-unit", readToken (min) |
19.1 KB | 13.8 KB | +38.28% |
| ⚡ | Memory | benchmark "cache-filesystem", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' |
1.4 MB | 1.1 MB | +29.55% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing docs/silent-wake-needs-no-message (8b97b17) with main (9fd4df5)
Footnotes
-
6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Summary
docs/pull-requests.mdalready says a wake that changes nothing ends with no message, and lists partial-upload coverage percentages and bot echoes among what never to narrate. One gap let it be followed in letter and missed in spirit: where the harness asks for visible output on an otherwise silent turn, the easiest answer is a line saying the wake needed no action — which is the narration the rule forbids.On #22397 that produced about twenty such lines over one run, reporting codecov recomputing 77% → 94% → 96% while its uploads landed. Each was accurate and none was worth reading.
Two sentences close it, next to the rule they qualify:
What kind of change does this PR introduce?
docs
Did you add tests for your changes?
n/a — prose in
docs/, which no suite reads.Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
This is the documentation. Nothing for the website:
docs/is not published, so there is no changeset either.Use of AI
Claude Code wrote this, and the gap is one it fell into on #22397 — it reported each intermediate coverage recompute instead of staying silent. I asked it to write the rule down rather than rely on remembering.
Generated by Claude Code
Summary by CodeRabbit