Repository navigation
fix: keep named re-export ids when the same request is star-reexport - #22351
Conversation
ad3f3b5 to
3472285
Compare
|
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: webpack/webpack/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughLazyBarrelController.request now collects forwarded IDs across direct and star re-exports, including recorded parent-barrel IDs. A new nested re-export test checks exported values and compilation modules with module concatenation enabled and disabled. ChangesLazy barrel re-export handling
Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to The change has no identified issue that needs resolution before merge. The nested re-export behavior has targeted regression coverage. 🚥 Pre-merge checks | ✅ 3 | ❓ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
Full details: Title checkExplanation The title uses the required Conventional Commit form with the allowed type Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
area: optimization
3472285 to
8bbc92e
Compare
|
This PR is packaged and the instant preview is available (045d2ab). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@045d2ab
yarn add -D webpack@https://pkg.pr.new/webpack@045d2ab
pnpm add -D webpack@https://pkg.pr.new/webpack@045d2ab |
Types CoverageCoverage after merging fix/lazy-barrel-named-and-star-reexport into main will be
Coverage Report |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22351 +/- ##
==========================================
+ Coverage 94.50% 95.74% +1.23%
==========================================
Files 767 770 +3
Lines 109227 109482 +255
Branches 34138 34198 +60
==========================================
+ Hits 103230 104823 +1593
+ Misses 5997 4659 -1338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Generated code sizeComparing base (
Read No asset that both runs emit changed size — everything below is new or deleted. 2 asset(s) this pull request adds
No runtime that both runs build changed which runtime modules it carries. 1 runtime(s) this pull request adds or no longer builds
Built |
8bbc92e to
ed2d98c
Compare
ed2d98c to
295d697
Compare
Merging this PR will improve performance by ×2.8
Performance Changes
Tip Curious why performance improved? Comment Comparing 
Footnotes
|
Summary
When a barrel re-exports one module both by name and with
export *, i.e.export { default as Button } from "./Button/index.mjs";export * from "./Button/index.mjs";the lazy barrel forwarded only the barrel's own names and dropped the named re-export's id, so the nested barrel never built its
defaulttarget and the import resolved toundefined.Now we merges the star-forwarded names with the named re-export ids of the same request.
cc @xiaoxiaojx
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changesou already documented?
n/a
Use of AI
Yes
Summary by CodeRabbit