Repository navigation
fix: hash inlined export literals at the dependency level - #22050
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughChangesInline export hashing
Suggested reviewers: Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to The cache rebuild path now updates inlined export values consistently, including side-effecting re-exports. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
Full details: Title checkExplanation The title uses the required Conventional Commit form, uses the allowed type "fix", and accurately describes dependency-level hashing for inlined export literals. The branch prefix is not provided, so the required type-prefix match cannot be verified. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR is packaged and the instant preview is available (cd0282c). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@cd0282c
yarn add -D webpack@https://pkg.pr.new/webpack@cd0282c
pnpm add -D webpack@https://pkg.pr.new/webpack@cd0282c |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22050 +/- ##
==========================================
+ Coverage 94.97% 94.98% +0.01%
==========================================
Files 726 726
Lines 97275 97285 +10
Branches 29629 29634 +5
==========================================
+ Hits 92386 92406 +20
+ Misses 4889 4879 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Generated code sizeComparing
No asset changed size. No runtime gained or lost a runtime module. Built |
3e7dd39 to
f3dfeb0
Compare
Merging this PR will degrade performance by 5.43%
|
f3dfeb0 to
0500b33
Compare
Types CoverageCoverage after merging fix/inline-exports-reexport-hash into main will be
Coverage Report |
Summary
Follow-up to #22020. Refs #22019.
ChunkGraphhash only kept inlinedHarmonyImportSpecifierDependencyconnections, so a re-exporter kept alive by its side effects still served a stale literal from its export getter after a cached rebuild.HarmonyImportSpecifierDependencyandHarmonyExportImportedSpecifierDependencynow feed the inlined literal intoupdateHashthemselves, which replaces theChunkGraphspecial case and theConstExportsPluginrefresh branch it needed.cc @xiaoxiaojx
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
n/a
Use of AI
Yes
Summary by CodeRabbit
Bug Fixes
Tests