Skip to content

feat: add support for new asset query suffixes - #21379

Merged
alexander-akait merged 1 commit into
webpack:mainfrom
bjohansebas:assets
Jul 11, 2026
Merged

alexander-akait merged 1 commit into
webpack:mainfrom
bjohansebas:assets

Conversation

@bjohansebas

Copy link
Copy Markdown
Member

…ne, and ?no-inline`

Summary
closes #333.

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

Copilot AI review requested due to automatic review settings July 10, 2026 20:00
@changeset-bot

changeset-bot Bot commented Jul 10, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d8bb9d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Jul 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.92%. Comparing base (5798eda) to head (d8bb9d9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21379   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files         601      601           
  Lines       68761    68763    +2     
  Branches    19350    19351    +1     
=======================================
+ Hits        63898    63901    +3     
+ Misses       4863     4862    -1     
Flag Coverage Δ
css-parsing 26.23% <50.00%> (+<0.01%) ⬆️
html5lib 27.82% <50.00%> (+<0.01%) ⬆️
integration 89.13% <100.00%> (+<0.01%) ⬆️
test262 42.91% <50.00%> (+<0.01%) ⬆️
unit 45.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Jul 10, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 1 regressed benchmark
✅ 145 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Memory benchmark "asset-modules-resource", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 175.4 KB 1,475.6 KB -88.12%
⚡ Memory benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 333.3 KB 142.5 KB ×2.3
⚡ Memory benchmark "asset-modules-inline", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 322 KB 215.5 KB +49.45%
⚡ Memory benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 298.4 KB 218.9 KB +36.32%
⚡ Memory benchmark "many-chunks-commonjs", scenario '{"name":"mode-production","mode":"production"}' 10.6 MB 7.9 MB +33.04%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing bjohansebas:assets (d8bb9d9) with main (5798eda)

Open in CodSpeed

Copilot AI review requested due to automatic review settings July 10, 2026 21:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@alexander-akait
alexander-akait merged commit 0f1df89 into webpack:main Jul 11, 2026
58 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

This PR is packaged and the instant preview is available (0f1df89).

Install it locally:

  • npm
npm i -D webpack@https://pkg.pr.new/webpack@0f1df89
  • yarn
yarn add -D webpack@https://pkg.pr.new/webpack@0f1df89
  • pnpm
pnpm add -D webpack@https://pkg.pr.new/webpack@0f1df89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Libraries that have both CommonJs and AMD definitions

3 participants