fix: VirtualUrlPlugin absolute-path virtual module IDs getting concatenated with compiler context#20656
Merged
alexander-akait merged 1 commit intomainfrom Mar 17, 2026
Conversation
…enated with compiler context When a virtual module ID is an absolute path (e.g. `virtual:C:/project/user.js`), context "auto" incorrectly joined the derived context with `compiler.context` via `path.join`, producing a concatenated path like `C:\cwd\C:\project`. Now absolute contexts are detected via `isAbsolute` (from `lib/util/fs`) and used directly. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
🦋 Changeset detectedLatest commit: cd4c62e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is packaged and the instant preview is available (6784091). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@6784091
yarn add -D webpack@https://pkg.pr.new/webpack@6784091
pnpm add -D webpack@https://pkg.pr.new/webpack@6784091 |
Contributor
Merging this PR will degrade performance by 29.12%
Performance Changes
Comparing 
|
alexander-akait
approved these changes
Mar 17, 2026
alexander-akait
deleted the
fix/virtual-url-plugin-absolute-path-context
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #20421 (comment)
When a virtual module ID is an absolute path (e.g.
virtual:C:/project/user.js), context "auto" incorrectly joined the derived context withcompiler.contextviapath.join, producing a concatenated path likeC:\cwd\C:\project. Now absolute contexts are detected viaisAbsolute(fromlib/util/fs) and used directly.What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing
Use of AI
Partial