Repository navigation
Conversation
|
|
|
alexander-akait
requested changes
Mar 13, 2026
alexander-akait
left a comment
Member
There was a problem hiding this comment.
This is wrong solution and the issue about libraries
Author
|
Ho @alexander-akait , could you please guide me in right direction on how to solve this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #15936
Until now when we were doing multiple imports in entry point as array, only the exports from the last entry would be available.With this PR, the exports should work for all the entry points.
What kind of change does this PR introduce?
This PR fixes the problem of exports only available from the last entry. They are fixed in three stages
1) when entry points is refrenced by other modules
Before
After
2) When entry points depend on other chunks
Before
After
3) When there are Inline entry modules
In this case , i avoid writing the exports variable inside iife for inline entry modules, this way all the entry modules use the global exports variable and thus exports from all extry points would be available.
Did you add tests for your changes?
yes i have added tests
Does this PR introduce a breaking change?
No Breaking Change
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Since exports from all the entry points will be available, we have to update the document in places where it says only exports
from last entry point will be available like here.
Use of AI
I have never used AI for this PR, it took me literally a week to understand and come to this solution.