feat(css): generate separate CssModule instances per exportType#20590
Merged
alexander-akait merged 3 commits intomainfrom Mar 6, 2026
Merged
feat(css): generate separate CssModule instances per exportType#20590alexander-akait merged 3 commits intomainfrom
alexander-akait merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 8611508 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is packaged and the instant preview is available (acf2165). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@acf2165
yarn add -D webpack@https://pkg.pr.new/webpack@acf2165
pnpm add -D webpack@https://pkg.pr.new/webpack@acf2165 |
alexander-akait
approved these changes
Mar 5, 2026
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good, for me it is more a fix, than feature
Merging this PR will degrade performance by 22.67%
Performance Changes
Comparing |
Member
|
Can you look why our tested are failed? |
Contributor
Member
Author
@alexander-akait Sorry for the delay. I've fixed it. |
alexander-akait
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(css): generate separate CssModule instances per exportType
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing