fix: add declaration for unused harmony import specifier#20286
Merged
alexander-akait merged 4 commits intomainfrom Jan 12, 2026
Merged
fix: add declaration for unused harmony import specifier#20286alexander-akait merged 4 commits intomainfrom
alexander-akait merged 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 34f5861 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is packaged and the instant preview is available (fd55587). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@fd55587
yarn add -D webpack@https://pkg.pr.new/webpack@fd55587
pnpm add -D webpack@https://pkg.pr.new/webpack@fd55587 |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
alexander-akait
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce?
Fixes #20151 and fixes #20276.
We will generate a var declaration (i.e.
var unused_import_specifier) for unused import specifiers to reduce the likelihood of the entry module being wrapped in an IIFE.Notably, the declaration will be safely removed after minimize, so i think the pros outweigh the costs.
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No