CodSpeed Performance Report

Merging #20170 will not alter performance

_{Comparing xiaoxiaojx:issue-20139-2 (87c5630) with main (c6215ca)}

Summary

✅ 69 untouched

@JSerFeng Can you look at this solution too, thanks?

We Rspack, want to provide a global variable that can let user interop with current runtime, for example:

__webpack_global__ will be transformed to the __webpack_require__ in the output.

Once this is done, there should be no __webpack_global__ in the output, plugin author can make sure they just interop with runtime of current compilation.

And this PR inject __webpack_global__ through the module factory parameter, I may missing something, what if the module is entry and is concatenated, no module factory at all

🦋 Changeset detected

Latest commit: 87c5630

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JSerFeng We use the module factory parameter here because we want to provide a stable runtime variable, similar to Node.js, without needing any build-time intervention. As shown in the screenshot, __webpack_global__ remains intact after bundling — it’s purely a runtime variable.

When __webpack_global__ is used, webpack will only set allowInlineStartup: false to preserve the existence of the module factory.

We’re not handling this problem in a very complex way for now, to be honest, the implementation of react-refresh is a bit of a hack. Now that this problem #20139 can be solved.

If loader and plugin wants to inject code to do something with current webpack runtime, f user code has already __webpack_global__ definition, does the output code can correctly access the current webpack runtime instead of the __webpack_global__ in user code

Replacing it at build time sounds like a good idea. It also reminded me of how __webpack_public_path__ is used — for example, Next.js has code like this:

__webpack_public_path__ = "https://example.com/public/path/";

We can implement it by following the existing behavior of __webpack_public_path__.

Thanks

This PR is packaged and the instant preview is available (5983843).

Install it locally:

• npm

npm i -D webpack@https://pkg.pr.new/webpack@5983843

• yarn

yarn add -D webpack@https://pkg.pr.new/webpack@5983843

• pnpm

pnpm add -D webpack@https://pkg.pr.new/webpack@5983843