Skip to content

fix: types and test#19558

Merged
alexander-akait merged 1 commit intomainfrom
fix-ts-types
May 23, 2025
Merged

fix: types and test#19558
alexander-akait merged 1 commit intomainfrom
fix-ts-types

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

refactor + fix typescript types + tests

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 23, 2025

CodSpeed Performance Report

Merging #19558 will degrade performances by 77.77%

Comparing fix-ts-types (f798957) with main (c9e25e5)

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 129 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 35.7 ms 43.6 ms -18.18%
benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 34.3 ms 11.6 ms ×3
benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 52.8 ms 61 ms -13.35%
benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 9.7 ms 43.6 ms -77.77%

@alexander-akait alexander-akait merged commit af1c86d into main May 23, 2025
42 of 44 checks passed
@alexander-akait alexander-akait deleted the fix-ts-types branch May 23, 2025 13:39
3ru pushed a commit to 3ru/webpack that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant