Skip to content

ci: add Node.js v23#18891

Closed
snitin315 wants to merge 2 commits intomainfrom
snitin315-patch-1
Closed

ci: add Node.js v23#18891
snitin315 wants to merge 2 commits intomainfrom
snitin315-patch-1

Conversation

@snitin315
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?
CI

Run tests on Node.js v23

Did you add tests for your changes?
NA

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Nothing

@webpack-bot
Copy link
Copy Markdown
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@snitin315
Copy link
Copy Markdown
Member Author

Looking intointegration (ubuntu-latest, 23.x, b)

@alexander-akait
Copy link
Copy Markdown
Member

@snitin315 Looks like regression in Node.js, - fs.readFile("/", (err) => {}), before err.code === "EISDIR", now no callback call and err.code === "ERR_FS_EISDIR"

@alexander-akait
Copy link
Copy Markdown
Member

Ref: nodejs/node#55609

@evenstensberg
Copy link
Copy Markdown
Member

Are we still blocked from the node regression? What does it need to fix this?

@alexander-akait
Copy link
Copy Markdown
Member

Close in favor - #18972

@alexander-akait alexander-akait deleted the snitin315-patch-1 branch November 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants