fix(types): Remove useless SortableSet iterator#18751
Closed
slorber wants to merge 1 commit intowebpack:mainfrom
Closed
fix(types): Remove useless SortableSet iterator#18751slorber wants to merge 1 commit intowebpack:mainfrom
slorber wants to merge 1 commit intowebpack:mainfrom
Conversation
Contributor
|
For maintainers only:
|
This was referenced Sep 10, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TypeScript 5.6 typing problem due to Iterator changes:
Useful links:
What kind of change does this PR introduce?
Remove custom iterator type for
SortableSet:The implementation does not create a custom iterator so IMHO this declaration could be removed to use the built-in parent Set iterator.
Note: the iterator type you previously used was the former built-in type. But that built-in type changed in TS 5.6. Refs:
BuiltinIterator/BuiltinIteratorReturnmicrosoft/TypeScript#59506Did you add tests for your changes?
Not sure how to test this, apart from upgrading the whole repo to TS 5.6
Does this PR introduce a breaking change?
It shouldn't?
What needs to be documented once your changes are merged?
Nothing?