Merged
Conversation
Contributor
|
For maintainers only:
|
jtbandes
reviewed
Aug 28, 2024
Comment on lines
+15
to
+17
| /** | ||
| * @param {(string | string[] | Record<string, string>)[]} keys keys | ||
| */ |
There was a problem hiding this comment.
@alexander-akait Hi there, it seems like this PR broke the types for EnvironmentPlugin. According to docs, both undefined and null are accepted as values (and have different behavior), however with this change it is no longer allowed to pass null: (playground link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix, we need
strictvalue for typescript to catch possible problems (around 1400 problems still need to fix)Did you add tests for your changes?
No need
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No