Support strictBuiltinIteratorReturn#18591
Merged
alexander-akait merged 2 commits intowebpack:mainfrom Jul 24, 2024
rbuckton:strictBuiltinIteratorReturn
Merged
Support strictBuiltinIteratorReturn#18591alexander-akait merged 2 commits intowebpack:mainfrom rbuckton:strictBuiltinIteratorReturn
alexander-akait merged 2 commits intowebpack:mainfrom
rbuckton:strictBuiltinIteratorReturn
Conversation
Contributor
|
For maintainers only:
|
Author
|
I've filed this as a Draft PR in the event there are any other changes to microsoft/TypeScript#58243 that must be addressed. Once that PR has merged, I will mark this PR as "Ready for review". |
alexander-akait
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This updates the
webpackbuild to be forwards compatible with microsoft/TypeScript#58243, which uses a stricter return type for built-in iterators under the newstrictBuiltinIteratorReturnoption, which is enabled by default when building withstrict.Did you add tests for your changes?
Tests should not be necessary for this change.
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing, this is purely related to TypeScript type checking of the
webpackproject itself.