add node-module option for node.__file/dirname#17931
Merged
alexander-akait merged 14 commits intowebpack:mainfrom Jan 10, 2024
Merged
add node-module option for node.__file/dirname#17931alexander-akait merged 14 commits intowebpack:mainfrom
alexander-akait merged 14 commits intowebpack:mainfrom
Conversation
evaluate __filename and __dirname for common js modules when output.module to fileURLToPath(import.meta.url) and fileURLToPath(import.meta.url + "/..") respectively
Co-authored-by: Tobias Koppers <[email protected]>
# Conflicts: # lib/dependencies/CachedConstDependency.js # schemas/WebpackOptions.check.js
# Conflicts: # schemas/WebpackOptions.check.js
# Conflicts: # lib/DependencyTemplate.js # lib/javascript/JavascriptGenerator.js # schemas/WebpackOptions.check.js # types.d.ts
Contributor
|
For maintainers only:
|
alexander-akait
approved these changes
Jan 9, 2024
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good for me, can you sign CLA?
Contributor
Author
|
@alexander-akait done, something else? |
Member
|
Thank you, release will be soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
closes #14072
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
new options node.__filename=node-module / node.__dirname=node-module
generate
__filenameand__dirnamefor common js modules when output.module=true tofileURLToPath(import.meta.url)andfileURLToPath(import.meta.url + "/..")respectivelyp.s. That is copy of #14247 with merge commit.