Repository navigation
Fix hot loader compatibility with Java8 Nashorn - #1709
Closed
pugnascotia wants to merge 1 commit into
Closed
pugnascotia wants to merge 1 commit into
pugnascotia wants to merge 1 commit into
Conversation
The way that the hot loader is included in a bundle breaks in Java 8's Nashorn engine, because of a missing semicolon. This change introduces a placeholder value that can be correctly substituted when building a bundle, but is otherwise inert. Note that I don't particularly like this change, so if there's a better fix, I'd like to hear about it.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way that the hot loader is included in a bundle breaks in Java 8's
Nashorn engine, because of a missing semicolon. This change introduces
a placeholder value that can be correctly substituted when building
a bundle, but is otherwise inert.
Note that I don't particularly like this change, so if there's a better
fix, I'd like to hear about it.