Repository navigation
add concatenate modules side effects test case, fix imports order - #15868
Merged
Merged
Conversation
Contributor
|
For maintainers only:
|
vankop
commented
May 27, 2022
vankop
changed the title
Member
|
Opting out of side effects also opts out of evaluation of modules in source order. So technically we are allowed to place side effect free modules in any order, but at least it must be deterministic. Without module concatenation modules are evaluated in usage order, so sorting by range start seems correct. Test case need to test the |
sokra
approved these changes
Jun 2, 2022
Contributor
|
@vankop Thank you for the fix! Are there any updates on when this might merge? |
Contributor
Author
|
@pgoldberg next release I guess.. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
add test case, fixes #15866
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing