Skip to content

keep hmr update with output.clean=true - #15405

Merged
sokra merged 2 commits into
mainfrom
fix/issue-15206
Feb 28, 2022
Merged

keep hmr update with output.clean=true#15405
sokra merged 2 commits into
mainfrom
fix/issue-15206

Conversation

@vankop

@vankop vankop commented Feb 16, 2022

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

fixes #15206

Did you add tests for your changes?

yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot

webpack-bot commented Feb 16, 2022

Copy link
Copy Markdown
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@vankop vankop mentioned this pull request Feb 22, 2022
Closed
@vankop vankop changed the title keep last hmr update with output.clean=true keep hmr update with output.clean=true Feb 26, 2022
sokra
sokra requested changes Feb 28, 2022
View reviewed changes
Comment thread lib/CleanPlugin.js Resolved
Comment thread lib/CleanPlugin.js Resolved
Comment thread lib/CleanPlugin.js Resolved
Comment thread lib/CleanPlugin.js Resolved
@webpack-bot

webpack-bot commented Feb 28, 2022

Copy link
Copy Markdown
Contributor

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@sokra

sokra commented Feb 28, 2022

Copy link
Copy Markdown
Member

Thanks

@sokra
sokra merged commit bb0fdc9 into main Feb 28, 2022
@sokra
sokra deleted the fix/issue-15206 branch February 28, 2022 15:35
@TrickyPi TrickyPi mentioned this pull request Mar 16, 2022
Closed
@erictheswift erictheswift mentioned this pull request Sep 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sokra sokra sokra approved these changes

Assignees

@sokra sokra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HMR not working on webpack 5.66.0

3 participants

@vankop @webpack-bot @sokra