fix ExportsInfo #15367

vankop · 2022-02-10T13:05:30Z

should mark every export canMangleProvide=false if there are unknown exports
add __webpack_exports_info__.<name>.canMangle to api
add test case

What kind of change does this PR introduce?

bugfix
fixes #15214

Did you add tests for your changes?

yes

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

add __webpack_exports_info__.<name>.canMangle to api

webpack-bot · 2022-02-10T13:05:34Z

For maintainers only:

This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
This needs to be backported to webpack 4 (issue will be created when merged)

- should mark every export canMangleProvide=false if there are unknown exports - add __webpack_exports_info__.<name>.canMangle to api - add test case

vankop · 2022-02-10T13:21:46Z

test/__snapshots__/StatsTestCases.basictest.js.snap

 webpack x.x.x compiled successfully in X ms

-asset main.no-side.js 979 bytes [emitted] [minimized] (name: main)
+asset main.no-side.js 993 bytes [emitted] [minimized] (name: main)


no mangling for one variable (same case with empty js file)

sokra · 2022-02-10T16:01:43Z

lib/dependencies/ExportsInfoDependency.js

+			const exportsInfo = moduleGraph.getExportsInfo(module);
+			const exportInfo = exportsInfo.getExportInfo(exportName);
+			if (exportInfo) return exportInfo.canMangle;
+			return exportsInfo.otherExportsInfo.canMangleProvide;


Why is that canMangleProvide and not canMangle?

Suggested change

return exportsInfo.otherExportsInfo.canMangleProvide;

return exportsInfo.otherExportsInfo.canMangle;

sokra · 2022-02-10T16:05:05Z

test/configCases/parsing/harmony-reexport/webpack.config.js

@@ -0,0 +1,2 @@
+/** @type {import("../../../../").Configuration} */
+module.exports = {};


When this doesn't need special config, we should move it into test/cases so it's tested with different configs.

Maybe wrapping some assertions with if(process.env.NODE_ENV === "production") (e. g. for optimizations that only run in production mode)

this was done intentionally to run 3 times (check for cache invalidation)

Ah yes that makes sense

moved to test/cases added cache invalidation stuff there as well

webpack-bot · 2022-02-11T08:10:50Z

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

vankop · 2022-02-11T12:36:09Z

test/TestCasesCachePack.longtest.js

+					test: "no-string"
+				},
+				{
+					// Pack got invalid because of write to: ResolverCachePlugin|normal|dependencyType=|esm|path=|/Users/ivankopeykin/Repositories/webpack/test/cases|request=|./large/big-assets/


fix in #15373

vankop · 2022-02-14T09:02:20Z

test/TestCasesCachePack.longtest.js

+		infrastructureLogErrors: {
+			compile: {
+				// Module build failed
+				["error-hide-stack"]:


maybe add this to errors.js file? cache-errors.js maybe?

sokra · 2022-02-14T10:55:27Z

test/ConfigCacheTestCases.longtest.js

-		filter: [logErrors.PERSISTENCE_CACHE_INVALIDATE_ERROR]
+		wasm: {
+			// Can not compile wasm module
+			["missing-wasm-experiment"]:


Suggested change

["missing-wasm-experiment"]:

"missing-wasm-experiment":

That's not necessary... but you can leave that for now

sokra · 2022-02-14T12:26:30Z

Thanks

webpack-bot · 2022-02-14T12:26:34Z

I've created an issue to document this in webpack/webpack.js.org.

webpack-bot added the PR: unreviewed label Feb 10, 2022

fix ExportsInfo

4830503

- should mark every export canMangleProvide=false if there are unknown exports - add __webpack_exports_info__.<name>.canMangle to api - add test case

vankop force-pushed the fix/issues-15214 branch from 69b6fca to 4830503 Compare February 10, 2022 13:21

vankop commented Feb 10, 2022

View reviewed changes

vankop assigned sokra Feb 10, 2022

sokra requested changes Feb 10, 2022

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Feb 10, 2022

vankop added 2 commits February 11, 2022 11:07

fix discussions

a905ea3

Merge branch 'main' into fix/issues-15214

8544f01

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Feb 11, 2022

remove unused test case

26a1916

vankop mentioned this pull request Feb 11, 2022

if cache pack is too big, we should batch writing #15373

Merged

vankop commented Feb 11, 2022

View reviewed changes

refactor infrastructure log functionality

1e7acc5

vankop commented Feb 14, 2022

View reviewed changes

sokra reviewed Feb 14, 2022

View reviewed changes

vankop force-pushed the fix/issues-15214 branch from 82cc542 to e4e9b7f Compare February 14, 2022 10:59

fix windows test cases, remove affected tests from allowlist

dc73156

vankop force-pushed the fix/issues-15214 branch from e4e9b7f to dc73156 Compare February 14, 2022 11:36

sokra merged commit 896efde into main Feb 14, 2022

sokra deleted the fix/issues-15214 branch February 14, 2022 12:26

webpack-bot mentioned this pull request Feb 14, 2022

Document webpack change: fix ExportsInfo webpack/webpack.js.org#5966

Closed

7rulnik mentioned this pull request Feb 14, 2022

Fix webpack cache invalidation storybookjs/storybook#17307

Closed

3 tasks

	return exportsInfo.otherExportsInfo.canMangleProvide;
	return exportsInfo.otherExportsInfo.canMangle;

		@@ -0,0 +1,2 @@
		/** @type {import("../../../../").Configuration} */
		module.exports = {};

Uh oh!

fix ExportsInfo #15367

fix ExportsInfo #15367

Uh oh!

Conversation

vankop commented Feb 10, 2022 • edited by sokra Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webpack-bot commented Feb 10, 2022 • edited by sokra Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vankop Feb 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sokra Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

sokra Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

vankop Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

sokra Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

vankop Feb 11, 2022

Choose a reason for hiding this comment

Uh oh!

webpack-bot commented Feb 11, 2022

Uh oh!

vankop Feb 11, 2022

Choose a reason for hiding this comment

Uh oh!

vankop Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sokra Feb 14, 2022

Choose a reason for hiding this comment

Uh oh!

sokra commented Feb 14, 2022

Uh oh!

webpack-bot commented Feb 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vankop commented Feb 10, 2022 •

edited by sokra

Loading

webpack-bot commented Feb 10, 2022 •

edited by sokra

Loading

vankop Feb 10, 2022 •

edited

Loading

vankop Feb 14, 2022 •

edited

Loading