Skip to content

handle several resources in ContextModule#15332

Merged
sokra merged 3 commits intomainfrom
fix/context-resolve-issue-11335
Feb 10, 2022
Merged

handle several resources in ContextModule#15332
sokra merged 3 commits intomainfrom
fix/context-resolve-issue-11335

Conversation

@vankop
Copy link
Copy Markdown
Member

@vankop vankop commented Feb 8, 2022

What kind of change does this PR introduce?

bugfix
fixes #11335

Did you add tests for your changes?

yes

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

nothing

@webpack-bot
Copy link
Copy Markdown
Contributor

webpack-bot commented Feb 8, 2022

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@vankop vankop force-pushed the fix/context-resolve-issue-11335 branch from 9a526be to 0c536d5 Compare February 8, 2022 08:06
@vankop vankop force-pushed the fix/context-resolve-issue-11335 branch from 0c536d5 to 9951d9d Compare February 8, 2022 08:12
sokra
sokra requested changes Feb 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks, otherwise fine

Comment thread lib/ContextModule.js Outdated
Comment thread lib/ContextModule.js Outdated
@webpack-bot
Copy link
Copy Markdown
Contributor

webpack-bot commented Feb 8, 2022

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@vankop vankop force-pushed the fix/context-resolve-issue-11335 branch 2 times, most recently from 41d6cfc to bcc978c Compare February 8, 2022 11:01
@vankop vankop force-pushed the fix/context-resolve-issue-11335 branch 3 times, most recently from cb28b82 to 477971a Compare February 8, 2022 16:27
@vankop vankop force-pushed the fix/context-resolve-issue-11335 branch from 477971a to cdfb610 Compare February 8, 2022 18:40
@sokra sokra merged commit 89c92bf into main Feb 10, 2022
@sokra
Copy link
Copy Markdown
Member

sokra commented Feb 10, 2022

Thanks

@sokra sokra deleted the fix/context-resolve-issue-11335 branch February 10, 2022 16:18
@nwalters512 nwalters512 mentioned this pull request Feb 16, 2022
Closed
sokra added a commit that referenced this pull request Feb 17, 2022
@sokra
Revert "Merge pull request #15332 from webpack/fix/context-resolve-is…
dd53923 
…sue-11335"

This reverts commit 89c92bf, reversing
changes made to a28af55.
vankop added a commit that referenced this pull request Feb 21, 2022
@vankop
Revert "Revert "Merge pull request #15332 from webpack/fix/context-re…
93d4484 
…solve-issue-11335""

This reverts commit dd53923.
diandiandidi519 pushed a commit to diandiandidi519/webpack that referenced this pull request Oct 23, 2022
@vankop
Revert "Revert "Merge pull request webpack#15332 from webpack/fix/con…
b01f821 
…text-resolve-issue-11335""

This reverts commit dd53923.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sokra sokra sokra approved these changes

Assignees

@sokra sokra

Labels

PR: reviewed-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

context module doesn't work with array of aliases

3 participants

@vankop @webpack-bot @sokra