docs(util): added jsdoc annotations for ArrayHelpers.js#15279
Merged
sokra merged 1 commit intowebpack:mainfrom Jan 31, 2022
Merged
docs(util): added jsdoc annotations for ArrayHelpers.js#15279sokra merged 1 commit intowebpack:mainfrom
sokra merged 1 commit intowebpack:mainfrom
Conversation
Contributor
|
For maintainers only:
|
taranek
force-pushed
the
docs/array-helpers-docs
branch
from
3cf3f49 to
c13e088
Compare
taranek
force-pushed
the
docs/array-helpers-docs
branch
from
c13e088 to
5a3760e
Compare
sokra
approved these changes
Jan 31, 2022
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, it's my first contribution to this repo, so I tried to find something easy to make my debut smoother. I hope I won't break contribution guidelines🤞
What kind of change does this PR introduce?
Adds missing JSDoc type annotations for
util/ArrayHelpers.jsfile.Improves type safety of
groupByandequalsutil methods by providing an optional type parameter representing the type of a single array element (which defaults toany).Did you add tests for your changes?
No.
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?
Nothing - it's just a small improvement of the existing documentation.