Disable compile time evaluation of import.meta.url by pavelsavara · Pull Request #15246 · webpack/webpack

pavelsavara · 2022-01-25T13:34:24Z

Problem

Current webpack 5 evaluates import.meta.url to file://some/path/to/source of the build machine.

Proposed changes

add new parser setting importMeta - enable/disable import.meta parsing

module.exports = {
  module: {
    parser: {
      javascript : { importMeta: false }
    }
  }
};

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?

New parser.javascript option importMeta - enable/disable import.meta parsing

linux-foundation-easycla · 2022-01-25T13:34:28Z

The committers are authorized under a signed CLA.

✅ Pavel Savara (73bb431)

webpack-bot · 2022-01-25T13:34:29Z

For maintainers only:

This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
This needs to be backported to webpack 4 (issue will be created when merged)

alexander-akait · 2022-01-25T13:38:21Z

This options should be implemented on module level, i.e. you can disable it for some modules, example of new URL(...) https://webpack.js.org/configuration/module/#moduleparserjavascripturl

- use it in ImportMetaPlugin to switch it off as necessary

alexander-akait · 2022-01-25T15:19:38Z

Looks good, can you accept CLA?

pavelsavara · 2022-01-26T09:50:42Z

Now I tested it that it works for my use case. I also tested that it keeps doing the original substitution by default.
I'm not sure if the other broken tests are relevant or how to fix them.
Could you please help me ?

alexander-akait · 2022-01-26T10:44:21Z

SyntaxError: Cannot use 'import.meta' outside a module

I think it is lack supported import.meta in tests, because we use vm.runInThisContext, we can:

Skip test
Refactor our tests and support it

alexander-akait · 2022-01-26T10:44:45Z

Run node_modules/.bin/jest test/TestCasesNormal.basictest.js

pavelsavara · 2022-01-26T12:17:14Z

Skip test

it.skip() would not work here as it's issue with parsing the module. Any other ideas ?

Refactor our tests and support it

I guess that something require individual test files ?
To be able to test ES6 modules, we would need to dynamic import it instead.
That should be ok even in vm.runInThisContext I think.

And that only for tests which are for the es6 module target, because things like __filename don't work in es6 module, so we could not switch all tests.

Could you advise what enumerates the test files?
Is that jest ?
https://jestjs.io/docs/ecmascript-modules

- enable/disable import.meta parsing - when disabled insert output.importMetaName

vankop · 2022-01-27T20:19:04Z

@pavelsavara thanks for starting PR, we discussed internally that importMeta: boolean option would be better. I have improved your PR

pavelsavara · 2022-01-27T21:42:49Z

Cool, feel free to take it over.
I wonder what fixed the SyntaxError: Cannot use 'import.meta' outside a module in the tests ?

vankop · 2022-01-28T05:52:07Z

not sure, I think syntax error was in vm context that was running without esm enabled

sokra

some nitpicks

webpack-bot · 2022-01-28T08:52:49Z

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

webpack-bot · 2022-04-08T07:49:18Z

I've created an issue to document this in webpack/webpack.js.org.

I'm affected by webpack/webpack#14445, fixed in webpack/webpack#15246, available in webpack >= [v5.68.0](https://github.com/webpack/webpack/releases/tag/v5.68.0), so I'd love to have an ncc version using webpack >= v5.68.0! Co-authored-by: Steven <[email protected]>

webpack-bot added the PR: unreviewed label Jan 25, 2022

pavelsavara mentioned this pull request Jan 25, 2022

Make import.meta.url dynamic #14445

Closed

- add new config section importMeta

73bb431

- use it in ImportMetaPlugin to switch it off as necessary

pavelsavara force-pushed the import_meta_url branch from b55db4f to 73bb431 Compare January 25, 2022 15:10

fix test

57f6e3b

pavelsavara marked this pull request as ready for review January 26, 2022 08:27

pavelsavara marked this pull request as draft January 26, 2022 08:36

fix

332fb11

pavelsavara marked this pull request as ready for review January 26, 2022 09:49

add importMeta to JavascriptParserOptions:

c09e82f

- enable/disable import.meta parsing - when disabled insert output.importMetaName

vankop force-pushed the import_meta_url branch from e1f4ad6 to c09e82f Compare January 27, 2022 19:54

vankop requested a review from sokra January 27, 2022 20:19

add test case

17e8eed

sokra requested changes Jan 28, 2022

View reviewed changes

Comment thread lib/config/defaults.js Outdated

Comment thread lib/dependencies/ImportMetaPlugin.js Outdated

webpack-bot added PR: reviewed-changes-requested PR: review-outdated and removed PR: unreviewed PR: reviewed-changes-requested labels Jan 28, 2022

fix discussions

232403c

vankop force-pushed the import_meta_url branch from 4714fb5 to 232403c Compare January 28, 2022 09:01

sokra approved these changes Jan 28, 2022

View reviewed changes

sokra merged commit 46e8639 into webpack:main Jan 28, 2022

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Jan 28, 2022

alexander-akait mentioned this pull request Jan 29, 2022

With library.type: module, import.meta.url shouldn't be replaced with static string #14809

Closed

fend25 mentioned this pull request Mar 18, 2022

Fix Vite build bundling error about EISDIR on new URL('.', import.meta.url) polkadot-js/dev#637

Merged

gfsd3v mentioned this pull request Mar 24, 2022

Add new webpack config for new URL('...', import.meta.url) angular/angular-cli#22888

Closed

bjoluc mentioned this pull request Mar 26, 2022

fix: Disable compile time evaluation of import.meta.url vercel/ncc#897

Merged

webpack-bot mentioned this pull request Apr 8, 2022

Document webpack change: Disable compile time evaluation of import.meta.url webpack/webpack.js.org#6087

Closed

pavelsavara mentioned this pull request May 26, 2022

[wasm][wbt] Test that dotnet.js could be run from any current directory dotnet/runtime#69441

Merged

WillyJL mentioned this pull request Aug 24, 2022

Fix local resource error on browser (#392) ffmpegwasm/ffmpeg.wasm#394

Merged

dhdaines mentioned this pull request Jan 26, 2023

Angular should disable webpack's import.meta.url parsing by default angular/angular-cli#24616

Closed

1 task

Uh oh!

Conversation

pavelsavara commented Jan 25, 2022 • edited by vankop Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Proposed changes

Uh oh!

linux-foundation-easycla Bot commented Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webpack-bot commented Jan 25, 2022 • edited by sokra Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexander-akait commented Jan 25, 2022

Uh oh!

alexander-akait commented Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pavelsavara commented Jan 26, 2022

Uh oh!

alexander-akait commented Jan 26, 2022

Uh oh!

alexander-akait commented Jan 26, 2022

Uh oh!

pavelsavara commented Jan 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vankop commented Jan 27, 2022

Uh oh!

pavelsavara commented Jan 27, 2022

Uh oh!

vankop commented Jan 28, 2022

Uh oh!

sokra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

webpack-bot commented Jan 28, 2022

Uh oh!

webpack-bot commented Apr 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pavelsavara commented Jan 25, 2022 •

edited by vankop

Loading

linux-foundation-easycla Bot commented Jan 25, 2022 •

edited

Loading

webpack-bot commented Jan 25, 2022 •

edited by sokra

Loading

alexander-akait commented Jan 25, 2022 •

edited

Loading

pavelsavara commented Jan 26, 2022 •

edited

Loading