add node-module option for node.__file/dirname by vankop · Pull Request #14247 · webpack/webpack

vankop · 2021-09-14T13:51:56Z

What kind of change does this PR introduce?

feature

closes #14072

Did you add tests for your changes?

yes

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

new options node.__filename=node-module / node.__dirname=node-module

generate __filename and __dirname for common js modules when output.module=true to
fileURLToPath(import.meta.url) and fileURLToPath(import.meta.url + "/..") respectively

evaluate __filename and __dirname for common js modules when output.module to fileURLToPath(import.meta.url) and fileURLToPath(import.meta.url + "/..") respectively

webpack-bot · 2021-09-14T13:52:00Z

For maintainers only:

This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
This needs to be backported to webpack 4 (issue will be created when merged)

test/configCases/output-module/node-globals/index.js

Co-authored-by: Tobias Koppers <[email protected]>

webpack-bot · 2021-09-20T16:14:27Z

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

webpack-bot · 2021-09-21T07:52:26Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

# Conflicts: # lib/dependencies/CachedConstDependency.js # schemas/WebpackOptions.check.js

sokra

Found these old review comments... not sure if they are still relevant

lib/dependencies/CachedConstDependency.js

lib/DependencyTemplate.js

test/configCases/output-module/node-globals/index.js

lib/NodeStuffPlugin.js

lib/dependencies/NodeUrlDependency.js

lib/javascript/JavascriptGenerator.js

sokra · 2021-09-21T08:42:00Z

lib/javascript/JavascriptGenerator.js

@@ -199,7 +199,8 @@ class JavascriptGenerator extends Generator {
 			runtime: generateContext.runtime,


Unrelated: For performance reasons we should only create templateContext once per module.

# Conflicts: # schemas/WebpackOptions.check.js

# Conflicts: # lib/DependencyTemplate.js # lib/javascript/JavascriptGenerator.js # schemas/WebpackOptions.check.js # types.d.ts

alexander-akait

@vankop can you rebase, I think we can merge it and I am fine with it, thank you

iamyamakin · 2024-01-09T01:15:05Z

@sokra do you mind if i create PR with a merge commit? I see a few conflicts between this branch and main:

lib/NodeStuffPlugin.js;
lib/config/defaults.js;
schemas/WebpackOptions.check.js.

snitin315 · 2024-01-09T03:06:02Z

I'll rebase this PR, no worries.

alexander-akait · 2024-01-09T13:56:30Z

Yeah, feel free to send again, I am fine with the such improve

webpack-bot · 2024-01-10T11:56:35Z

I've created an issue to document this in webpack/webpack.js.org.

add node-module option for node.__file/dirname

6c3a04d

evaluate __filename and __dirname for common js modules when output.module to fileURLToPath(import.meta.url) and fileURLToPath(import.meta.url + "/..") respectively

webpack-bot added the PR: unreviewed label Sep 14, 2021

fix consts

9da9aed

webpack-bot added the PR: CI-not-ok label Sep 14, 2021

vankop added 4 commits September 14, 2021 21:23

use chunkInitFragments

04a4660

add test case

7c5f2cd

fix lint

4af7304

fix test

fdc3fcd

alexander-akait mentioned this pull request Sep 20, 2021

__dirname and __filename should not be provided for target: web #14229

Closed

sokra requested changes Sep 20, 2021

View reviewed changes

test/configCases/output-module/node-globals/index.js Outdated Show resolved Hide resolved

test/configCases/output-module/node-globals/index.js Outdated Show resolved Hide resolved

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Sep 20, 2021

fix for windows. apply suggestions from code review

a32a493

Co-authored-by: Tobias Koppers <[email protected]>

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Sep 20, 2021

fix test case

bf01661

vankop force-pushed the feature-14072 branch from 4e83305 to bf01661 Compare September 21, 2021 07:20

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Sep 21, 2021

Merge branch 'main' into feature-14072

166be71

# Conflicts: # lib/dependencies/CachedConstDependency.js # schemas/WebpackOptions.check.js

webpack-bot added the PR: conflict label Nov 16, 2021

sokra reviewed Nov 26, 2021

View reviewed changes

vankop added 2 commits November 30, 2021 13:56

Merge branch 'main' into feature-14072

c243a4b

# Conflicts: # schemas/WebpackOptions.check.js

fix discussion

405ce48

webpack-bot removed the PR: conflict label Nov 30, 2021

Merge branch 'main' into feature-14072

d6d6fb5

# Conflicts: # lib/DependencyTemplate.js # lib/javascript/JavascriptGenerator.js # schemas/WebpackOptions.check.js # types.d.ts

vankop force-pushed the feature-14072 branch from bd2c6fb to fe70e75 Compare April 5, 2022 09:48

vankop force-pushed the feature-14072 branch from fe70e75 to 2526f90 Compare April 5, 2022 10:07

fixes

0ee3a99

vankop force-pushed the feature-14072 branch from 2526f90 to 0ee3a99 Compare April 5, 2022 10:08

fregante mentioned this pull request Oct 5, 2022

ESM builds should substitute __filename and __dirname references in CommonJS #14072

Closed

alexander-akait approved these changes Dec 25, 2023

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Dec 25, 2023

iamyamakin mentioned this pull request Jan 9, 2024

add node-module option for node.__file/dirname #17931

Merged

alexander-akait merged commit ce6b061 into main Jan 10, 2024

alexander-akait deleted the feature-14072 branch January 10, 2024 11:56

webpack-bot mentioned this pull request Jan 10, 2024

Document webpack change: add node-module option for node.__file/dirname webpack/webpack.js.org#7095

Closed

		@@ -199,7 +199,8 @@ class JavascriptGenerator extends Generator {
		runtime: generateContext.runtime,

Uh oh!

Comments

Conversation

vankop commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webpack-bot commented Sep 14, 2021 • edited by vankop Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webpack-bot commented Sep 20, 2021

Uh oh!

webpack-bot commented Sep 21, 2021

Uh oh!

sokra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sokra Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

alexander-akait left a comment

Choose a reason for hiding this comment

Uh oh!

iamyamakin commented Jan 9, 2024

Uh oh!

snitin315 commented Jan 9, 2024

Uh oh!

alexander-akait commented Jan 9, 2024

Uh oh!

webpack-bot commented Jan 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vankop commented Sep 14, 2021 •

edited

Loading

webpack-bot commented Sep 14, 2021 •

edited by vankop

Loading