Skip to content

Conversation

@vankop
Copy link
Member

@vankop vankop commented Jul 8, 2020

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

updated snapshots

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

webpack supports options.resolve.roots option. Defaults to options.context.

If request is an server-relative URL (starting with /) webpack will try to resolve path.join(root[i], request) after trying to resolve the path as absolute path on non-windows systems

@webpack-bot
Copy link
Contributor

webpack-bot commented Jul 8, 2020

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@vankop
Copy link
Member Author

vankop commented Jul 9, 2020

need to update CLI snapshots..

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

I've created an issue to document this in webpack/webpack.js.org.

@sokra
Copy link
Member

sokra commented Jul 9, 2020

Thanks

@vankop vankop deleted the add-roots branch July 9, 2020 11:22
@webpack-bot
Copy link
Contributor

I've created an issue to backport this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants