Skip to content

Conversation

@sokra
Copy link
Member

@sokra sokra commented May 19, 2020

#10889

  • Using module in an ESM no longer needs the whole namespace object
  • SideEffects flag can follow reexports that are partially dynamic or use a compat default
  • export * uses more exports info data for better exports
  • dynamic export * no longer flags the default export as maybe provided

What kind of change does this PR introduce?
bugfix, optimization

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

webpack-bot commented May 19, 2020

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra force-pushed the bugfixes/side-effect-optimization branch from 933d92e to adf9ef6 Compare May 19, 2020 01:16
@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 4d3b021 into master May 19, 2020
@sokra sokra deleted the bugfixes/side-effect-optimization branch May 19, 2020 08:10
@webpack-bot
Copy link
Contributor

I've created an issue to backport this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants