Skip to content

feat: cli flags - #10515

Merged
sokra merged 31 commits into
masterfrom
feat-cli-flags
Mar 26, 2020
Merged

sokra merged 31 commits into
masterfrom
feat-cli-flags

Conversation

@alexander-akait

@alexander-akait alexander-akait commented Mar 6, 2020 •

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

features, cli flags for webpack-cli

fixes #10499

also a lot of fixes and linting for schemas

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

@webpack-bot

Copy link
Copy Markdown
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@vankop

vankop commented Mar 7, 2020

Copy link
Copy Markdown
Contributor

@evilebottnawi what do you think about adding comment on top of cli-flags.js about autogeneration, e.g. "Do not modify file manually use ..."?

@webpack-bot

Copy link
Copy Markdown
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

sokra added 8 commits March 25, 2020 23:48
handle array + single items by default in cli args
sort schema one/any/allOf array by type
exclude some deprecated options
improve reference support in compile-to-definitions
stricter schema linting
oneOf for references
anyOf for alternatives
@webpack-bot

Copy link
Copy Markdown
Contributor

The minimum test ratio has been reached. Thanks!

@sokra
sokra merged commit 630bf17 into master Mar 26, 2020
@sokra
sokra deleted the feat-cli-flags branch March 26, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants