Skip to content

[WIP] feat: exposing flags via webpack - #10499

Closed
ematipico wants to merge 2 commits into
webpack:masterfrom
ematipico:feature/expose-flags
Closed

ematipico wants to merge 2 commits into
webpack:masterfrom
ematipico:feature/expose-flags

Conversation

@ematipico

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
New feature where webpack exposes flags. These flags will be useful for CLI and other tools.
Closes #10435

Did you add tests for your changes?
Not needed for now but I will once the PR is ready for merging.

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Probably nothing, I think

@webpack-bot

Copy link
Copy Markdown
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@ematipico

ematipico commented Mar 3, 2020 •

Copy link
Copy Markdown
Contributor Author

@evilebottnawi @sokra so this is a first implementation of what's in the roadmap for the CLI. For now I just copied what we have in webpack-cli and exposed (I removed what's not needed). Tell me, from here:

  • what to add
  • what to change
  • what to implement
  • how to implement

@webpack-bot

Copy link
Copy Markdown
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export flags for webpack-cli from webpack

2 participants