Skip to content

fix: bundle wrong modules #10146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sokra merged 2 commits into from
Dec 18, 2019
Merged

fix: bundle wrong modules #10146

sokra merged 2 commits into from
Dec 18, 2019

Conversation

@liximomo
Copy link
Contributor

@liximomo liximomo commented Dec 18, 2019 •
edited
Loading

This PR fixes #10144

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Yes.

Does this PR introduce a breaking change?
No

@webpack-bot
Copy link
Contributor

webpack-bot commented Dec 18, 2019

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

webpack-bot commented Dec 18, 2019

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@liximomo liximomo changed the title fix: prevent incorrectly redirect fix: bundle wrong modules Dec 18, 2019
@sokra sokra merged commit ab4fa8d into webpack:webpack-4 Dec 18, 2019
@sokra
Copy link
Member

sokra commented Dec 18, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: CI-ok PR: non-main PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liximomo @webpack-bot @sokra