Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimization.realContentHash does not respect output.hashSalt #16788

Closed
dmichon-msft opened this issue Mar 7, 2023 · 0 comments · Fixed by #16789
Closed

optimization.realContentHash does not respect output.hashSalt #16788

dmichon-msft opened this issue Mar 7, 2023 · 0 comments · Fixed by #16789

Comments

@dmichon-msft
Copy link
Contributor

Bug report

What is the current behavior?
Assets with [contenthash] in the filename template do not produce different hashes when changing the value of the output.hashSalt webpack configuration property, if optimization.realContentHash is true.

If the current behavior is a bug, please provide the steps to reproduce.
Create a trivial webpack project with a [contenthash] in the output filename template and optimization.realContentHash set to true.
Vary the value of the output.hashSalt property and observe that emitted filenames don't change.

What is the expected behavior?
Changing the value of output.hashSalt should change the results of all filename hashes.

Inspection of the code here:

webpack/lib/optimize/RealContentHashPlugin.js

Lines 365 to 368 in b67626c

const hash = createHash(this._hashFunction);
for (const content of assetsContent) {
hash.update(content);
}

Shows that RealContentHashPlugin does not look up outputOptions.hashSalt and apply it to the newly created Hash object.

Other relevant information:
webpack version: 5.75.0
Node.js version: 16.19.1
Operating System: Linux
Additional tools:
dmichon-msft pushed a commit to dmichon-msft/webpack that referenced this issue Mar 8, 2023
Fix webpack#16788
819a04e 
Update RealContentHashPlugin to initialize hash instances with
the value of `output.hashSalt`, if provided.
dmichon-msft pushed a commit to dmichon-msft/webpack that referenced this issue Mar 8, 2023
Fix webpack#16788
cc0b9d8 
Update RealContentHashPlugin to initialize hash instances with
the value of `output.hashSalt`, if provided.
@dmichon-msft dmichon-msft mentioned this issue Mar 8, 2023
Merged
dmichon-msft added a commit to dmichon-msft/webpack that referenced this issue Mar 8, 2023
@dmichon-msft
Fix webpack#16788
63e2f42 
Update RealContentHashPlugin to initialize hash instances with
the value of `output.hashSalt`, if provided.
dmichon-msft added a commit to dmichon-msft/webpack that referenced this issue Mar 8, 2023
@dmichon-msft
Respect output.hashSalt in RealContentHashPlugin
07283fa 
Fix webpack#16788

Update RealContentHashPlugin to initialize hash instances with
the value of `output.hashSalt`, if provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect output.hashSalt in RealContentHashPlugin dmichon-msft/webpack
1 participant
@dmichon-msft