You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit f9ed9d1
Browse filesBrowse the repository at this point in the historyBrowse files
fix(css): fold no block of a layer over a streamed block of that layer (#22044)
* test(css): hold the printers to real framework stylesheets
The equivalence check ran over configCases and test/wpt, both written to
exercise a rule rather than to ship. The tool comparisons already install
thirty framework stylesheets and two documents, so this reads them back as
a corpus of their own and holds both printers to what Chrome makes of them.
Each comparison now runs only as the entry point and says where its
fixtures land, so the corpus is read from where it is declared rather than
copied. A cache that has not been built is reported, not skipped silently.
Co-authored-by: aryanraj45 <[email protected]>
* ci: install the comparison corpus for the equivalence suite
The stylesheets and documents the tool comparisons install are read by the
equivalence suite, which until now found them only on a machine that had
run a comparison by hand. Each script gains a `--setup` mode that installs
the fixtures without measuring anything, and the job runs it.
The install is not fatal: the suite already reads whichever fixtures are
there and names the tier as not built when there are none, so a registry
outage costs that corpus rather than the job.
Co-authored-by: aryanraj45 <[email protected]>
* test(css): read a repeated selector's properties from its own blocks
A selector written twice was compared through a round trip: the blocks were
concatenated as `cssText` and re-parsed, and the properties read off that.
Chrome serializes a shorthand awaiting substitution as longhands with no
value, which do not re-parse, so `border-bottom:var(--x) solid` lost its
style and width longhands and the rule compared unequal to the same rule
written once.
The concatenation still stands, since a percentage resolves against the
earlier declarations, but the properties and their specified values now come
from the blocks themselves.
Co-authored-by: aryanraj45 <[email protected]>
* fix(css): fold no block of a layer over a streamed block of that layer
Sibling blocks of one named layer are gathered into the first, which is
sound because a named layer's blocks are one layer wherever they stand and
the order within it is kept. A block large enough to stream is emitted
without passing through that gather, so it neither folded nor cleared it,
and a later block of its layer folded in front of it.
The order within a layer is the one the cascade reads, so that moved rules
past ones that could override them. A streamed block now clears its
parent's gather, which is what a block the gather cannot see has to do.
Co-authored-by: aryanraj45 <[email protected]>
* test(css): read a repeated selector's importance as the cascade does
A selector written twice took the later block's value for every property,
but CSS Cascade 4 §6.2 keeps an important declaration over a normal one
written after it — so `.a{--x:red!important}.a{--x:blue}` compared unequal
to the one rule the cascade reads it as.
The comparison corpus is installed in one step per cache too: `run` stops
at the first command that fails, so a single block cost both corpora where
only one install went wrong.
Co-authored-by: aryanraj45 <[email protected]>
---------
Co-authored-by: aryanraj45 <[email protected]>
0 commit comments