Skip to content

Commit f89d43d

Browse files
test: report an error from closing the compiler after a failed build
Claude-Session: https://claude.ai/code/session_017TkBWTk3wcyUcJYDp5ZhaP
1 parent b69fe0e commit f89d43d

3 files changed

Lines changed: 11 additions & 4 deletions

File tree

‎.changeset/060-resolver-cache-closed-compiler.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
"webpack": patch
33
---
44

5-
Do not throw when a compiler is closed while a cached resolve is still in progress, e.g. after a build with `bail` failed.
5+
Keep a resolve that ends after the compiler closed from throwing.

‎test/templates/ConfigTestCases.js‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,10 @@ const describeCases = (config) => {
329329
* @param {(err?: Error) => void} done done callback
330330
*/
331331
const closeAfterFatalError = (compiler, err, done) => {
332-
compiler.close(() => handleFatalError(err, done));
332+
compiler.close((closeErr) => {
333+
if (closeErr) return done(closeErr);
334+
handleFatalError(err, done);
335+
});
333336
};
334337

335338
/**

‎test/templates/TestCases.js‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,9 @@ const describeCases = (config) => {
421421
const stats = /** @type {import("../../").Stats} */ (_stats);
422422
const deprecations = deprecationTracker();
423423
// closed so its cache does not store after the test, see ConfigTestCases
424-
if (err) return compiler.close(() => done(err));
424+
if (err) {
425+
return compiler.close((closeErr) => done(closeErr || err));
426+
}
425427
const infrastructureLogErrors = [
426428
...filterInfraStructureErrors(infraStructureLog, {
427429
run: 3,
@@ -510,7 +512,9 @@ const describeCases = (config) => {
510512
const deprecationTracker = deprecationTracking.start();
511513
compiler.run((err) => {
512514
deprecationTracker();
513-
if (err) return compiler.close(() => done(err));
515+
if (err) {
516+
return compiler.close((closeErr) => done(closeErr || err));
517+
}
514518
run();
515519
});
516520
} else {

0 commit comments

Comments
 (0)