You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit eb56f10
Browse filesBrowse the repository at this point in the historyBrowse files
fix(css): read a relative color's channel keyword as the number it names
CSS Color 5 §4.1 substitutes a channel keyword as a `<number>`, so `calc(h + 40)`
reduces to no unit at all and a hue slot reads it as degrees — the printer asked
for an angle there and left every expression over a hue written out. An angle
still stands where no keyword is mixed into it, and mixing the two is no value,
which stays declined.
The margins the color conversions rest on are now re-derivable rather than
remembered: `yarn measure:color-agreement` asks an engine for its own conversion
instead of for a pixel, prints how far it sits from webpack's in linear light and
through the transfer alone, and names the spaces it reads through a different
transfer function. It reproduces both constants and both spaces.
The verification itself is a test rather than a session's own run: the syntax
equivalence suite now sweeps a seeded corpus of ~12k color rewrites — every
spelling, mixes and relative references two levels deep — and paints each beside
the color it replaced, in six seconds.
-`hot/` — Runtime code shipped to browsers for HMR (browser-side, not Node tooling).
93
93
-`bin/` — `webpack` CLI entry point.
94
-
-`tooling/` — Repo-internal scripts: build/codegen (runtime/wasm generators, hash-debug tool) invoked by `yarn fix:special`, plus standalone analysis tools such as `compare-css-minifiers.js` / `compare-html-minifiers.js` (`yarn benchmark:css-minifiers`, `yarn benchmark:html-minifiers`). Those two need no arguments and no reading of their source: each runs webpack's CSS/HTML minifier and the ecosystem's over popular framework stylesheets and real documents, printing one table per fixture — output size raw and under gzip/brotli/zstd (the `test:size` settings), best-of-3 wall and cpu ms, peak RSS (each minifier × fixture measured in its own worker process, so the numbers are attributable), and whether the output lost classes / changed the DOM ("rejects it" rows mean the tool errored on that input). They install the packages they compare against into `node_modules/.cache/` on first run rather than into webpack's dependencies; expect the first run to install for a minute and every full run to take a few.
94
+
- `tooling/` — Repo-internal scripts: build/codegen (runtime/wasm generators, hash-debug tool) invoked by `yarn fix:special`, plus standalone analysis tools such as `compare-css-minifiers.js` / `compare-html-minifiers.js` (`yarn benchmark:css-minifiers`, `yarn benchmark:html-minifiers`). Those two need no arguments and no reading of their source: each runs webpack's CSS/HTML minifier and the ecosystem's over popular framework stylesheets and real documents, printing one table per fixture — output size raw and under gzip/brotli/zstd (the `test:size` settings), best-of-3 wall and cpu ms, peak RSS (each minifier × fixture measured in its own worker process, so the numbers are attributable), and whether the output lost classes / changed the DOM ("rejects it" rows mean the tool errored on that input). They install the packages they compare against into `node_modules/.cache/` on first run rather than into webpack's dependencies; expect the first run to install for a minute and every full run to take a few. `measure-color-agreement.js` (`yarn measure:color-agreement`) is the third: it asks a real browser for its own color conversions rather than for a pixel, and prints how far they sit from webpack's — which is where the rounding margins in `lib/css/syntax.js` and the list of spaces an engine reads through another transfer come from. Re-run it (a few seconds; `PUPPETEER_EXECUTABLE_PATH` picks the binary) rather than adjusting either by hand.
95
95
-`assembly/` — WebAssembly source for the hash function.
0 commit comments