Skip to content

Commit cbf8de9

Browse files
fix: type regression
1 parent 8e50ef2 commit cbf8de9

File tree

6 files changed

+14
-9
lines changed

6 files changed

+14
-9
lines changed

.changeset/yellow-donkeys-fold.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"webpack": patch
3+
---
4+
5+
Fixed `WebpackPluginInstance` type regression.

declarations/WebpackOptions.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1896,7 +1896,7 @@ export interface WebpackPluginInstance {
18961896
/**
18971897
* The run point of the plugin, required method.
18981898
*/
1899-
apply: import("../lib/webpack").WebpackPluginInstance;
1899+
apply: import("../lib/webpack").WebpackPluginInstanceApplyFunction;
19001900
[k: string]: any;
19011901
}
19021902
/**

lib/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ const memoize = require("./util/memoize");
3333
/** @typedef {import("../declarations/WebpackOptions").StatsOptions} StatsOptions */
3434
/** @typedef {import("../declarations/WebpackOptions").WebpackOptions} Configuration */
3535
/** @typedef {import("../declarations/WebpackOptions").WebpackOptionsNormalized} WebpackOptionsNormalized */
36-
/** @typedef {import("./webpack").WebpackPluginFunction} WebpackPluginFunction */
37-
/** @typedef {import("./webpack").WebpackPluginInstance} WebpackPluginInstance */
36+
/** @typedef {import("../declarations/WebpackOptions").WebpackPluginFunction} WebpackPluginFunction */
37+
/** @typedef {import("../declarations/WebpackOptions").WebpackPluginInstance} WebpackPluginInstance */
3838
/** @typedef {import("./ChunkGroup")} ChunkGroup */
3939
/** @typedef {import("./Compiler").AssetEmittedInfo} AssetEmittedInfo */
4040
/** @typedef {import("./Compilation").Asset} Asset */

lib/webpack.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const memoize = require("./util/memoize");
3232
/** @typedef {import("./Stats")} Stats */
3333

3434
/** @typedef {(this: Compiler, compiler: Compiler) => void} WebpackPluginFunction */
35-
/** @typedef {(compiler: Compiler) => void} WebpackPluginInstance */
35+
/** @typedef {(compiler: Compiler) => void} WebpackPluginInstanceApplyFunction */
3636

3737
const getValidateSchema = memoize(() => require("./validateSchema"));
3838

schemas/WebpackOptions.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6049,7 +6049,7 @@
60496049
"apply": {
60506050
"description": "The run point of the plugin, required method.",
60516051
"instanceof": "Function",
6052-
"tsType": "import('../lib/webpack').WebpackPluginInstance"
6052+
"tsType": "import('../lib/webpack').WebpackPluginInstanceApplyFunction"
60536053
}
60546054
},
60556055
"required": ["apply"]

types.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12432,8 +12432,8 @@ declare interface Optimization {
1243212432
| ""
1243312433
| 0
1243412434
| ((this: Compiler, compiler: Compiler) => void)
12435-
| "..."
1243612435
| WebpackPluginInstance
12436+
| "..."
1243712437
)[];
1243812438

1243912439
/**
@@ -12576,8 +12576,8 @@ declare interface OptimizationNormalized {
1257612576
*/
1257712577
minimizer?: (
1257812578
| ((this: Compiler, compiler: Compiler) => void)
12579-
| "..."
1258012579
| WebpackPluginInstance
12580+
| "..."
1258112581
)[];
1258212582

1258312583
/**
@@ -12696,8 +12696,8 @@ type OptimizationNormalizedWithDefaults = OptimizationNormalized & {
1269612696
minimize: NonNullable<undefined | boolean>;
1269712697
minimizer: (
1269812698
| ((this: Compiler, compiler: Compiler) => void)
12699-
| "..."
1270012699
| WebpackPluginInstance
12700+
| "..."
1270112701
)[];
1270212702
nodeEnv: NonNullable<undefined | string | false>;
1270312703
};
@@ -19890,7 +19890,6 @@ declare namespace exports {
1989019890
this: Compiler,
1989119891
compiler: Compiler
1989219892
) => void;
19893-
export type WebpackPluginInstance = (compiler: Compiler) => void;
1989419893
export type ExternalItemFunctionCallback = (
1989519894
data: ExternalItemFunctionData,
1989619895
callback: (
@@ -20013,6 +20012,7 @@ declare namespace exports {
2001320012
StatsOptions,
2001420013
Configuration,
2001520014
WebpackOptionsNormalized,
20015+
WebpackPluginInstance,
2001620016
ChunkGroup,
2001720017
AssetEmittedInfo,
2001820018
Asset,

0 commit comments

Comments
 (0)