feat: consider asset module as side-effect-free

hai-x · hai-x · commit c56b046729a2 · 2026-01-24T20:37:16.000+08:00
diff --git a/lib/asset/AssetBytesParser.js b/lib/asset/AssetBytesParser.js
@@ -9,6 +9,7 @@ const Parser = require("../Parser");
 
 /** @typedef {import("../Module").BuildInfo} BuildInfo */
 /** @typedef {import("../Module").BuildMeta} BuildMeta */
+/** @typedef {import("../Module").FactoryMeta} FactoryMeta */
 /** @typedef {import("../Parser").ParserState} ParserState */
 /** @typedef {import("../Parser").PreparsedAst} PreparsedAst */
 
@@ -30,6 +31,10 @@ class AssetBytesParser extends Parser {
 		/** @type {BuildMeta} */
 		(state.module.buildMeta).defaultObject = false;
 
+		const factoryMeta =
+			state.module.factoryMeta || (state.module.factoryMeta = {});
+		factoryMeta.sideEffectFree = true;
+
 		return state;
 	}
 }
diff --git a/lib/asset/AssetParser.js b/lib/asset/AssetParser.js
@@ -11,6 +11,7 @@ const Parser = require("../Parser");
 /** @typedef {import("../../declarations/WebpackOptions").AssetParserOptions} AssetParserOptions */
 /** @typedef {import("../Module").BuildInfo} BuildInfo */
 /** @typedef {import("../Module").BuildMeta} BuildMeta */
+/** @typedef {import("../Module").FactoryMeta} FactoryMeta */
 /** @typedef {import("../Parser").ParserState} ParserState */
 /** @typedef {import("../Parser").PreparsedAst} PreparsedAst */
 
@@ -32,7 +33,6 @@ class AssetParser extends Parser {
 		if (typeof source === "object" && !Buffer.isBuffer(source)) {
 			throw new Error("AssetParser doesn't accept preparsed AST");
 		}
-
 		const buildInfo =
 			/** @type {BuildInfo} */
 			(state.module.buildInfo);
@@ -62,6 +62,10 @@ class AssetParser extends Parser {
 			throw new Error("Unexpected dataUrlCondition type");
 		}
 
+		const factoryMeta =
+			state.module.factoryMeta || (state.module.factoryMeta = {});
+		factoryMeta.sideEffectFree = true;
+
 		return state;
 	}
 }
diff --git a/lib/asset/AssetSourceParser.js b/lib/asset/AssetSourceParser.js
@@ -9,6 +9,7 @@ const Parser = require("../Parser");
 
 /** @typedef {import("../Module").BuildInfo} BuildInfo */
 /** @typedef {import("../Module").BuildMeta} BuildMeta */
+/** @typedef {import("../Module").FactoryMeta} FactoryMeta */
 /** @typedef {import("../Parser").ParserState} ParserState */
 /** @typedef {import("../Parser").PreparsedAst} PreparsedAst */
 
@@ -30,6 +31,10 @@ class AssetSourceParser extends Parser {
 		/** @type {BuildMeta} */
 		(state.module.buildMeta).defaultObject = false;
 
+		const factoryMeta =
+			state.module.factoryMeta || (state.module.factoryMeta = {});
+		factoryMeta.sideEffectFree = true;
+
 		return state;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ const Parser = require("../Parser");`
`11`	`11`	`/** @typedef {import("../../declarations/WebpackOptions").AssetParserOptions} AssetParserOptions */`
`12`	`12`	`/** @typedef {import("../Module").BuildInfo} BuildInfo */`
`13`	`13`	`/** @typedef {import("../Module").BuildMeta} BuildMeta */`
	`14`	`+/** @typedef {import("../Module").FactoryMeta} FactoryMeta */`
`14`	`15`	`/** @typedef {import("../Parser").ParserState} ParserState */`
`15`	`16`	`/** @typedef {import("../Parser").PreparsedAst} PreparsedAst */`
`16`	`17`
`@@ -32,7 +33,6 @@ class AssetParser extends Parser {`
`32`	`33`	`if (typeof source === "object" && !Buffer.isBuffer(source)) {`
`33`	`34`	`throw new Error("AssetParser doesn't accept preparsed AST");`
`34`	`35`	`}`
`35`		`-`
`36`	`36`	`const buildInfo =`
`37`	`37`	`/** @type {BuildInfo} */`
`38`	`38`	`(state.module.buildInfo);`
`@@ -62,6 +62,10 @@ class AssetParser extends Parser {`
`62`	`62`	`throw new Error("Unexpected dataUrlCondition type");`
`63`	`63`	`}`
`64`	`64`
	`65`	`+ const factoryMeta =`
	`66`	`+ state.module.factoryMeta \|\| (state.module.factoryMeta = {});`
	`67`	`+ factoryMeta.sideEffectFree = true;`
	`68`	`+`
`65`	`69`	`return state;`
`66`	`70`	`}`
`67`	`71`	`}`