Repository navigation
Commit b54c5e2
authored
perf(config): read only the browserslist config for the default target (#22324)
* perf(config): read only the browserslist config for the default target
Choosing the default target asks one question — does a browserslist config
exist — and answered it by loading browserslist, which pulls caniuse-lite,
node-releases, electron-to-chromium and baseline-browser-mapping: 1.65 MB
retained for the whole build, of which a build with no such config uses
nothing.
browserslist's config half is a module of its own, the same instance the
queries use, so its caches stay shared. Asking that instead costs 334 KB and
loads the query data only where a config is found. Start-up heap on a
956-module development build drops 20,728 KB to 19,385 KB, and the saving
holds to peak (58,292 KB to 56,924 KB).
* test(config): read the default-target cases off the environment and the cache keys
The child inherited BROWSERSLIST and BROWSERSLIST_CONFIG, which browserslist
reads as a config of their own, so the no-config case answered browserslist
where either was set. It now runs without them.
It also matched require.cache keys by substring, which no forward-slash entry
does on Windows. Asking require.cache by the request's resolved path reads the
key Node wrote, so the configured case can assert the whole list.
* refactor(config): drop the fallback for an unresolvable browserslist config half
No suite can reach it: browserslist's own entry requires that module, so a
packaging change hiding it would already break the handler's own require of
browserslist, and the fallback would answer for a build that cannot run.1 parent 6ae31d7 commit b54c5e2
4 files changed
Lines changed: 97 additions & 0 deletions
File tree
- .changeset
- lib/config
- test/unitCases
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
19 | 29 | | |
20 | 30 | | |
21 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
15 | 20 | | |
16 | 21 | | |
17 | 22 | | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
21 | 31 | | |
22 | 32 | | |
23 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
167 | 168 | | |
168 | 169 | | |
169 | 170 | | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
170 | 242 | | |
0 commit comments