Skip to content

Commit b493986

Browse files
committed
perf: avoid duplicate scans in module concatenation
1 parent 759b539 commit b493986

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"webpack": patch
3+
---
4+
5+
Reduce repeated scans when concatenating imported modules.

‎lib/optimize/ConcatenatedModule.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1471,8 +1471,6 @@ class ConcatenatedModule extends Module {
14711471
if (runtimeCondition === false) continue;
14721472
const nonDeferAccess = !defer;
14731473
const module = connection.module;
1474-
if (targets === undefined) targets = [module];
1475-
else if (!targets.includes(module)) targets.push(module);
14761474
const dependency = connection.dependency;
14771475
if (
14781476
dependency !== null &&
@@ -1483,6 +1481,8 @@ class ConcatenatedModule extends Module {
14831481
}
14841482
const entry = referencesMap.get(module);
14851483
if (entry === undefined) {
1484+
if (targets === undefined) targets = [module];
1485+
else targets.push(module);
14861486
referencesMap.set(module, {
14871487
connection,
14881488
runtimeCondition,

0 commit comments

Comments
 (0)