Skip to content

Commit adb64f6

Browse files
docs(pull-requests): say that nothing to report means an empty answer (#22404)
The rule that a wake changing nothing ends with no message left one gap: a harness asking for visible output invites a line saying the wake needed no action, which is the narration the rule forbids. Over a run of twenty such wakes those lines bury the one that mattered.
1 parent 9fd4df5 commit adb64f6

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

‎docs/pull-requests.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,4 +231,6 @@ Every webpack PR is reviewed automatically on the initial commit and every push,
231231

232232
**Never narrate the rest** — intermediate coverage recomputes, partial-upload percentages, bot echoes (changeset, preview publish, "review in progress"), a check turning green, lists of job states. That buries the one wake that matters.
233233

234+
**Nothing to report means an empty answer**, including where the harness asks for visible output: return nothing rather than the status line that request invites. A line saying a wake needed no action is the narration this forbids, and twenty of them over one run read as noise around the wake that did.
235+
234236
Silence isn't skipping: read every event and investigate what it names; this governs only what reaches the requester. A finding judged an artifact is still reported once, with evidence ([see above](#after-opening-the-pr--every-check-ends-green)).

0 commit comments

Comments
 (0)