Skip to content

Commit ad3cb3a

Browse files
test: type the ObjectMiddleware round-trip context
`ObjectMiddleware`'s serialize/deserialize take a context carrying a logger, and deserialize returns a value that may be a promise, so `{}` and a bare `[0]` failed `lint:types-test` on CI.
1 parent 917e090 commit ad3cb3a

1 file changed

Lines changed: 15 additions & 6 deletions

File tree

‎test/ObjectMiddleware.unittest.js‎

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,31 @@
11
"use strict";
22

3+
const { Logger } = require("../lib/logging/Logger");
34
const ObjectMiddleware = require("../lib/serialization/ObjectMiddleware");
45
const SerializerMiddleware = require("../lib/serialization/SerializerMiddleware");
56

67
const middleware = new ObjectMiddleware(() => {}, "xxhash64");
8+
// Only the error paths log, so a sink is enough
9+
/** @type {Logger} */
10+
const logger = new Logger(
11+
() => {},
12+
() => logger
13+
);
14+
const context = { logger };
715

816
/**
917
* Round-trips a value through serialize + deserialize.
1018
* @param {EXPECTED_ANY} value the value to round-trip
1119
* @returns {EXPECTED_ANY} what came back
1220
*/
1321
const roundTrip = (value) => {
14-
const serialized = middleware.serialize([value], {});
22+
const serialized = middleware.serialize([value], context);
1523
expect(serialized).not.toBeNull();
16-
return middleware.deserialize(
24+
const deserialized = middleware.deserialize(
1725
/** @type {EXPECTED_ANY} */ (serialized),
18-
{}
19-
)[0];
26+
context
27+
);
28+
return /** @type {EXPECTED_ANY[]} */ (deserialized)[0];
2029
};
2130

2231
describe("ObjectMiddleware", () => {
@@ -97,15 +106,15 @@ describe("ObjectMiddleware", () => {
97106

98107
it("rejects a function that is not lazy", () => {
99108
expect(() =>
100-
middleware.serialize([/** @type {EXPECTED_ANY} */ (() => {})], {})
109+
middleware.serialize([/** @type {EXPECTED_ANY} */ (() => {})], context)
101110
).toThrow(/Unexpected function/);
102111
});
103112

104113
it("rejects a circular reference", () => {
105114
/** @type {EXPECTED_ANY} */
106115
const circular = {};
107116
circular.self = circular;
108-
expect(() => middleware.serialize([circular], {})).toThrow(
117+
expect(() => middleware.serialize([circular], context)).toThrow(
109118
/circular references/
110119
);
111120
});

0 commit comments

Comments
 (0)