Repository navigation
Commit ad3249b
authored
* fix(css): split @value imports on the from keyword
parseValueAtRuleParams located the `from` separator in
`@value <names> from <source>` with `str.lastIndexOf("from")`. When the
source path or an import name contained the substring `from` (e.g.
`./from-colors.module.css`), the split landed inside the path, so names
and source were mis-parsed and the import never resolved.
Split on the first whitespace-delimited `from` keyword instead, matching
postcss-modules-values semantics. Comments are already replaced with
spaces before the split, so the keyword is reliably whitespace-delimited.
Signed-off-by: Eshiv Pandey <[email protected]>
* fix(css): restrict @value from separator to CSS whitespace
JS \s also matches U+00A0 and other spaces that are valid inside an
import name, which could select a from inside the name; limit both
separator boundaries to the CSS whitespace set (space, tab, LF, FF, CR).
Signed-off-by: Eshiv Pandey <[email protected]>
---------
Signed-off-by: Eshiv Pandey <[email protected]>
1 parent 58156d6 commit ad3249b
6 files changed
Lines changed: 72 additions & 6 deletions
File tree
- .changeset
- lib/css
- test/configCases/css/css-modules-value-from-in-path
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
564 | 564 | | |
565 | 565 | | |
566 | 566 | | |
567 | | - | |
568 | | - | |
569 | | - | |
570 | | - | |
571 | | - | |
572 | | - | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
573 | 575 | | |
574 | 576 | | |
575 | 577 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
0 commit comments