Skip to content

Commit a725b23

Browse files
test(minify): retire the rival entries webpack now beats, list the comparisons gzip prefers the other way
Weigh a longer unmangled name against the copy it saves before reading a parameter through it. Claude-Session: https://claude.ai/code/session_01ViD41i2KdwwGxrDk7yrjeD
1 parent 7c51bd8 commit a725b23

4 files changed

Lines changed: 42 additions & 76 deletions

File tree

‎lib/javascript/syntax-printer.js‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24505,10 +24505,12 @@ const installImprove = (modules) => {
2450524505
if (
2450624506
!variable ||
2450724507
parameterDefinition.identifiers.length !== 1 ||
24508-
// Unmangled, a longer name read more than once may outweigh the call.
24509-
(value.name.length > parameter.name.length &&
24510-
parameterDefinition.references.length > 1 &&
24511-
!compressor._mangle_options) ||
24508+
// Unmangled, a longer name read often costs more than the `var` that
24509+
// would copy it.
24510+
(!compressor._mangle_options &&
24511+
(value.name.length - parameter.name.length) *
24512+
parameterDefinition.references.length >
24513+
parameter.name.length + value.name.length + 6) ||
2451224514
variable.undeclared ||
2451324515
variable.global ||
2451424516
variable.identifiers.length !== 1 ||

‎test/helpers/oxcSmaller.js‎

Lines changed: 11 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ const OXC_SMALLER_BY_REASON = [
4747
"swc exec: object_freeze_spread_computed_registration",
4848
"swc exec: terser_arguments_modified",
4949
"swc exec: terser_async_async_inline",
50-
"swc exec: terser_class_properties_static_means_execution",
5150
"swc exec: terser_drop_unused_drop_var",
5251
"swc exec: terser_drop_unused_issue_t183",
5352
"swc exec: terser_issue_1321_issue_1321_debug",
@@ -62,7 +61,6 @@ const OXC_SMALLER_BY_REASON = [
6261
"swc exec: terser_reduce_vars_unsafe_evaluate_side_effect_free_1",
6362
"swc minifier: fixture/issues/10281/input.js",
6463
"swc minifier: fixture/issues/10412/input.js",
65-
"swc minifier: fixture/issues/10824/input.js",
6664
"swc minifier: fixture/issues/10859/input.js",
6765
"swc minifier: fixture/issues/10885/input.js",
6866
"swc minifier: fixture/issues/11368/input.js",
@@ -93,7 +91,6 @@ const OXC_SMALLER_BY_REASON = [
9391
"swc minifier: fixture/issues/9186/1/input.js",
9492
"swc minifier: fixture/issues/9460/safe-initializers/input.js",
9593
"swc minifier: fixture/issues/arguments-canonical-index/input.js",
96-
"swc minifier: fixture/issues/drop-console-value-refs/input.js",
9794
"swc minifier: fixture/issues/number-radix-conversion/input.js",
9895
"swc minifier: fixture/projects/backbone/16/input.js",
9996
"swc minifier: fixture/projects/backbone/6/input.js",
@@ -163,7 +160,6 @@ const OXC_SMALLER_BY_REASON = [
163160
"terser compress: mangleprops-mangleprop-annotation/mangleprop_annotation",
164161
"terser compress: mangleprops-mangleprop-annotation/mangleprop_annotation_partial",
165162
"terser compress: new/new_statements_3",
166-
"terser compress: numbers/comparisons",
167163
"terser compress: numbers/evaluate_1",
168164
"terser compress: numbers/evaluate_2",
169165
"terser compress: object/getter_setter",
@@ -301,7 +297,6 @@ const OXC_SMALLER_BY_REASON = [
301297
"oxc minifier: peephole/minimize_conditions.rs:1294",
302298
"oxc minifier: peephole/minimize_conditions.rs:1295",
303299
"oxc minifier: peephole/minimize_conditions.rs:1296",
304-
"oxc minifier: peephole/minimize_conditions.rs:1298",
305300
"oxc minifier: peephole/minimize_conditions.rs:1305",
306301
"oxc minifier: peephole/minimize_conditions.rs:1306",
307302
"oxc minifier: peephole/minimize_conditions.rs:1307",
@@ -327,12 +322,9 @@ const OXC_SMALLER_BY_REASON = [
327322
"real-world code, where the gap sums several of the transforms above; split it once those land",
328323
[
329324
"swc exec: emotion_react_1",
330-
"swc minifier: benches-full/three.js",
331325
"swc minifier: fixture/issues/d3-color/1/input.js",
332-
"swc minifier: fixture/next/41527/1/input.js",
333326
"swc minifier: fixture/next/66237/input.js",
334327
"swc minifier: fixture/next/asmjs/1/input.js",
335-
"swc minifier: fixture/next/regression-1/framework-798bab57daac3897/input.js",
336328
"swc minifier: fixture/projects/jquery/11/input.js",
337329
"swc minifier: fixture/projects/next/extra/if_return/.4/input.js",
338330
"swc minifier: projects/files/backbone-1.1.0.js",
@@ -459,38 +451,10 @@ const OXC_SMALLER_BY_REASON = [
459451
"terser compress: destructuring/destructuring_decl_of_computed_key",
460452
"terser compress: drop-unused/issue_1968",
461453
"terser compress: drop-unused/issue_t161_top_retain_15",
462-
"terser compress: mangleprops-computed/computed_props_keep_quoted_inlined_sub_1",
463454
"terser compress: mangleprops-computed/computed_props_keep_quoted_inlined_sub_10",
464-
"terser compress: mangleprops-computed/computed_props_keep_quoted_inlined_sub_4",
465-
"terser compress: mangleprops-computed/computed_props_keep_quoted_inlined_sub_5",
466455
"terser compress: mangleprops-computed/computed_props_keep_quoted_inlined_sub_6",
467-
"terser compress: mangleprops-computed/computed_props_keep_quoted_inlined_sub_8",
468-
"terser compress: mangleprops-computed/computed_props_keep_quoted_inlined_sub_9",
469-
"terser compress: mangleprops-computed/computed_props_keep_quoted_property_access_sub",
470-
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_inlined_sub_3",
471-
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_inlined_sub_4",
472-
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_inlined_sub_5",
473-
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_inlined_sub_7",
474-
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_inlined_sub_8",
475-
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_inlined_sub_9",
476-
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_optional_property_access_sub",
477-
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_property_access_sub",
478-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_1",
479456
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_10",
480-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_4",
481-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_5",
482-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_6",
483-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_8",
484-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_9",
485-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_property_access_sub",
486-
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_inlined_sub_3",
487-
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_inlined_sub_4",
488-
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_inlined_sub_5",
489-
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_inlined_sub_7",
490-
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_inlined_sub_8",
491-
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_inlined_sub_9",
492-
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_optional_property_access_sub",
493-
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_property_access_sub"
457+
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_6"
494458
]
495459
],
496460
[
@@ -538,7 +502,6 @@ const OXC_SMALLER_BY_REASON = [
538502
"swc minifier: fixture/issues/12299/input.js",
539503
"swc minifier: fixture/issues/do-while-false-terminal-jump/rejected/input.js",
540504
"swc minifier: fixture/projects/backbone/5/input.js",
541-
"swc minifier: fixture/projects/jquery/.17/input.js",
542505
"swc minifier: fixture/projects/react/16/input.js",
543506
"terser compress: collapse_vars/issue_2873_1",
544507
"terser compress: conditionals/issue_1674_false_equivalency_of_props",
@@ -571,12 +534,7 @@ const OXC_SMALLER_BY_REASON = [
571534
"swc minifier: fixture/issues/array-constructor-length/input.js",
572535
"swc minifier: fixture/projects/backbone/15/input.js",
573536
"swc minifier: fixture/projects/backbone/2/input.js",
574-
"terser compress: class-properties/static_means_execution",
575-
"terser compress: conditionals/issue_ternary_and_nullish_coalescing_operator",
576-
"terser compress: evaluate/issue_2535_3",
577537
"terser compress: inline/dont_inline_funcs_into_default_param_2",
578-
"terser compress: issue-1446/typeof_eq_undefined",
579-
"terser compress: issue-1446/typeof_eq_undefined_ie8",
580538
"terser compress: nullish/conditional_to_nullish_coalescing_2"
581539
]
582540
],
@@ -602,16 +560,8 @@ const OXC_SMALLER_BY_REASON = [
602560
"swc exec: terser_properties_join_object_assignments_2",
603561
"terser compress: arrow/async_object_literal",
604562
"terser compress: arrow/issue_3092b",
605-
"terser compress: mangleprops-computed/computed_props_keep_quoted_inlined_sub_3",
606-
"terser compress: mangleprops-computed/computed_props_keep_quoted_inlined_sub_7",
607-
"terser compress: mangleprops-computed/computed_props_keep_quoted_optional_property_access_sub",
608-
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_inlined_sub_1",
609563
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_inlined_sub_10",
610564
"terser compress: mangleprops-computed/no_computed_props_keep_quoted_inlined_sub_6",
611-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_3",
612-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_inlined_sub_7",
613-
"terser compress: mangleprops-strict-computed/computed_props_keep_quoted_optional_property_access_sub",
614-
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_inlined_sub_1",
615565
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_inlined_sub_10",
616566
"terser compress: mangleprops-strict-computed/no_computed_props_keep_quoted_inlined_sub_6",
617567
"terser compress: object/concise_methods_with_various_property_names",
@@ -744,8 +694,7 @@ const OXC_SMALLER_BY_REASON = [
744694
"oxc minifier: peephole/minimize_statements.rs:137",
745695
"oxc minifier: peephole/minimize_statements.rs:141",
746696
"oxc minifier: peephole/minimize_statements.rs:188",
747-
"oxc minifier: peephole/minimize_statements.rs:195",
748-
"oxc minifier: peephole/minimize_statements.rs:374"
697+
"oxc minifier: peephole/minimize_statements.rs:195"
749698
]
750699
],
751700
[
@@ -793,11 +742,7 @@ const OXC_SMALLER_BY_REASON = [
793742
],
794743
[
795744
"oxc resolves a `switch` on a known value, or writes a `switch` shorter",
796-
[
797-
"swc minifier: fixture/issues/10918/input.js",
798-
"terser compress: switch/collapse_same_branches_not_in_a_row_ensure_no_evaluate_elad",
799-
"terser compress: switch/issue_445"
800-
]
745+
["swc minifier: fixture/issues/10918/input.js"]
801746
],
802747
[
803748
"oxc writes `if` statements shorter, as oxc's `peephole/minimize_if_statement.rs` tests show",
@@ -884,6 +829,14 @@ const OXC_SMALLER_BY_REASON = [
884829
[
885830
"oxc's output is wrong: it reads a `let` that a skipped `case` declares as its value, where the input throws a ReferenceError in the binding's dead zone",
886831
["oxc minifier: peephole/minimize_switch_statements.rs:65"]
832+
],
833+
[
834+
"webpack's output is as long as oxc's or shorter, yet gzips a byte or two bigger once an equality's literal is written last",
835+
[
836+
"swc exec: issue_11517_continue",
837+
"swc minifier: fixture/projects/jquery/2/input.js",
838+
"terser compress: if_return/if_return_8"
839+
]
887840
]
888841
];
889842

‎test/helpers/swcSmaller.js‎

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,6 @@ const SWC_SMALLER_BY_REASON = [
279279
"swc minifier: fixture/issues/cycle-1/input.js",
280280
"swc minifier: fixture/issues/cycle-2/input.js",
281281
"swc minifier: fixture/issues/pure-callee-call/input.js",
282-
"swc minifier: fixture/next/47005/input.js",
283282
"swc minifier: fixture/pr/7690/input.js",
284283
"swc minifier: fixture/simple/inline/4/input.js",
285284
"swc minifier: full/issues/8288/input.js",
@@ -563,7 +562,6 @@ const SWC_SMALLER_BY_REASON = [
563562
"swc minifier: fixture/issues/quagga2/1.4.2/1/input.js",
564563
"swc minifier: fixture/issues/react-autosuggest/1/input.js",
565564
"swc minifier: fixture/issues/react-autowhatever/1/input.js",
566-
"swc minifier: fixture/issues/react-countup/1/input.js",
567565
"swc minifier: fixture/issues/react-instancesearch/002/input.js",
568566
"swc minifier: fixture/issues/vercel/005/input.js",
569567
"swc minifier: fixture/next/33458/static/chunks/pages/spread-be872e60d968a0f7/input.js",
@@ -580,9 +578,6 @@ const SWC_SMALLER_BY_REASON = [
580578
"swc minifier: fixture/projects/next/.archive-4/266-aee26c928109d49d6151/input.js",
581579
"swc minifier: fixture/projects/next/.archive-4/pages/development-logs/link-with-no-prefetch-53313deb99cf94686856/input.js",
582580
"swc minifier: fixture/projects/next/.archive-4/pages/development-logs/link-with-prefetch-false-13db3186d6589f014e19/input.js",
583-
"swc minifier: fixture/projects/next/archive-2/pages/.development-logs-2ac9e724502f3ba1f1de/input.js",
584-
"swc minifier: fixture/projects/next/archive-2/pages/.dynamic-098d0d54bd014f190920/input.js",
585-
"swc minifier: fixture/projects/next/archive-2/pages/.hmr-ce649615cbc9a3b4c1ce/input.js",
586581
"swc minifier: fixture/projects/next/archive-2/pages/hmr/.counter-c6a48518c4a56e4d9ce5/input.js",
587582
"swc minifier: fixture/projects/next/archive-2/pages/hmr/.error-in-gip-bd210c03b443f903b86d/input.js",
588583
"swc minifier: fixture/projects/next/archive-2/pages/hmr/.style-stateful-component-6cd7bdfa37b75acb9d04/input.js",
@@ -666,6 +661,25 @@ const SWC_SMALLER_BY_REASON = [
666661
[
667662
"swc's output gzips a byte smaller where webpack's is shorter raw: a value collapsed into the key it is written under, where swc keeps the `name=` statement gzip matched",
668663
["swc minifier: fixture/projects/jquery/20/input.js"]
664+
],
665+
[
666+
"webpack writes `x===null` where swc's output, as the source, writes `null===x`: shorter or as long, this small program gzips a byte or three bigger, where larger ones gzip smaller",
667+
[
668+
"swc minifier: fixture/issues/stylis/1/input.js",
669+
"swc minifier: fixture/issues/stylis/2/input.js",
670+
"swc minifier: fixture/projects/backbone/14/input.js",
671+
"swc minifier: fixture/projects/jquery/11/input.js",
672+
"swc minifier: fixture/projects/jquery/2/input.js",
673+
"swc minifier: fixture/projects/next/.archive-4/webpack-eb940a9a97802b481f9b/input.js",
674+
"swc minifier: fixture/projects/next/extra/if_return/.4/input.js",
675+
"swc minifier: fixture/projects/react/15/input.js",
676+
"swc minifier: fixture/projects/react/9/input.js",
677+
"swc minifier: pass-1/4/input.js",
678+
"swc minifier: pass-1/5/input.js",
679+
"terser compress: comparing/issue_2857_2",
680+
"terser compress: comparing/issue_2857_3",
681+
"terser compress: if_return/if_return_8"
682+
]
669683
]
670684
];
671685

‎test/specCases/minify-corpora.spectest.js‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1317,10 +1317,6 @@ const IMPROVED_YET_BIGGER = {
13171317
"10 bytes fewer, 2 more gzipped: `var o=-9` split from `{p:-9}` breaks the `var o={p:` runs of the functions around it",
13181318
"arrow/object_parens (its own options)":
13191319
"3 bytes fewer, 1 more gzipped: `+!!{}` breaks the `()=>(` runs of the arrows around it gzip reused",
1320-
"inline/inline_into_scope_conflict_enclosed_2 (reminify 2 {\"mangle\":false})":
1321-
"5 bytes fewer, 1 more gzipped: `{x();return}` breaks the `return x()` run the function before it repeats",
1322-
"fixture/issues/d3-color/1/input.js (the default minimizer's options)":
1323-
"2 bytes fewer, 1 more gzipped: `p*e*h` breaks the `h*(` runs of the products beside it gzip reused",
13241320
"harmony/issue_2345 (the default minimizer's options)":
13251321
"10 bytes fewer, 7 more gzipped: the folded `[3,2,1].join(\"-\")` matched the one left after it",
13261322
"harmony/issue_2345 (reminify 2 {\"mangle\":false})":
@@ -1568,7 +1564,6 @@ for (const [reason, keys] of /** @type {[string, string[]][]} */ ([
15681564
"S11.9.5_A2.1_T1.js (the default minimizer's options)",
15691565
"S15.10.1_A1_T14.js (the default minimizer's options)",
15701566
"S15.10.1_A1_T16.js (the default minimizer's options)",
1571-
"S15.10.2.11_A1_T1.js (the default minimizer's options)",
15721567
"S15.10.3.1_A2_T1.js (the default minimizer's options)",
15731568
"S15.10.4.1_A1_T4.js (the default minimizer's options)",
15741569
"S15.10.4.1_A8_T12.js (the default minimizer's options)",
@@ -1587,7 +1582,6 @@ for (const [reason, keys] of /** @type {[string, string[]][]} */ ([
15871582
"S15.4.4.5_A3.2_T1.js (the default minimizer's options)",
15881583
"S15.4.4.5_A3.2_T2.js (the default minimizer's options)",
15891584
"S15.4.4.6_A1.1_T1.js (the default minimizer's options)",
1590-
"S15.4.4.6_A1.2_T1.js (the default minimizer's options)",
15911585
"S15.4.4.9_A1.1_T1.js (the default minimizer's options)",
15921586
"S15.4.4.9_A1.2_T1.js (the default minimizer's options)",
15931587
"S15.5.1.1_A1_T19.js (the default minimizer's options)",
@@ -1642,7 +1636,6 @@ for (const [reason, keys] of /** @type {[string, string[]][]} */ ([
16421636
"S11.1.6_A3_T7.js (the default minimizer's options)",
16431637
"S12.6.2_A2.js (the default minimizer's options)",
16441638
"S13.2.2_A15_T1.js (the default minimizer's options)",
1645-
"S13.2.2_A16_T2.js (the default minimizer's options)",
16461639
"S13.2.2_A16_T3.js (the default minimizer's options)",
16471640
"S13_A1.js (the default minimizer's options)",
16481641
"S14_A3.js (the default minimizer's options)",
@@ -1704,7 +1697,6 @@ for (const [reason, keys] of /** @type {[string, string[]][]} */ ([
17041697
[
17051698
"an assignment moved into the `var` before it, where the source repeats the assignment gzip matched",
17061699
[
1707-
"S11.4.7_A2.2_T1.js (the default minimizer's options)",
17081700
"S11.4.8_A2.2_T1.js (the default minimizer's options)",
17091701
"S11.8.4_A2.1_T1.js (the default minimizer's options)",
17101702
"S11.8.6_A2.1_T1.js (the default minimizer's options)",
@@ -1876,8 +1868,13 @@ for (const [reason, keys] of /** @type {[string, string[]][]} */ ([
18761868
"a script's top-level `let` read for its value, where the name it replaces repeated in a run gzip matched",
18771869
[
18781870
"byteOffset-validated-against-initial-buffer-length.js (the default minimizer's options)",
1879-
"fromEpochMilliseconds.js (the default minimizer's options)"
1871+
"fromEpochMilliseconds.js (the default minimizer's options)",
1872+
"true-for-timeout.js (the default minimizer's options)"
18801873
]
1874+
],
1875+
[
1876+
"`this===void 0` and `let` written where the source's `void 0===this` and `const` repeated in a run gzip matched",
1877+
["fixture/issues/9460/strict-mode/input.js (its own options)"]
18811878
]
18821879
])) {
18831880
for (const key of keys) IMPROVED_YET_BIGGER[key] = reason;

0 commit comments

Comments
 (0)